Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3)

Issue 1589013004: Remove the dependency on "path". (Closed)

Created:
3 years, 10 months ago by nweiz
Modified:
3 years, 10 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/string_scanner@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove the dependency on "path". We never imported this, so it's not clear why the dependency was even added. Closes #2 R=rnystrom@google.com Committed: https://github.com/dart-lang/string_scanner/commit/40eb613e0fa6f5e8150c583c48e5238a472e0640

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
nweiz
3 years, 10 months ago (2016-01-14 21:30:28 UTC) #1
Bob Nystrom
lgtm
3 years, 10 months ago (2016-01-15 00:23:25 UTC) #2
nweiz
3 years, 10 months ago (2016-01-15 00:29:26 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
40eb613e0fa6f5e8150c583c48e5238a472e0640 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698