third_party/WebKit/Source/core/svg/SVGStringList.cpp - Issue 1588993005: Extended error reporting for SVG attribute parsing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGStringList.cpp

Issue 1588993005: Extended error reporting for SVG attribute parsing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: TestExpectations Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/svg/SVGStringList.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGStringList.cpp b/third_party/WebKit/Source/core/svg/SVGStringList.cpp

index 120a4d383ffe9607107b376ddbc61a93ab7ee0dd..a97cb322343bac3f7294f6b9adda41d5e1244966 100644

--- a/third_party/WebKit/Source/core/svg/SVGStringList.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGStringList.cpp

@@ -108,7 +108,7 @@ SVGParsingError SVGStringList::setValueAsString(const String& data)

m_values.clear();

if (data.isEmpty())

- return NoError;

+ return SVGStatus::NoError;

if (data.is8Bit()) {

const LChar* ptr = data.characters8();

@@ -119,7 +119,7 @@ SVGParsingError SVGStringList::setValueAsString(const String& data)

const UChar* end = ptr + data.length();

parseInternal(ptr, end);

}

- return NoError;

+ return SVGStatus::NoError;

}

String SVGStringList::valueAsString() const