Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(725)

Unified Diff: third_party/WebKit/Source/core/svg/SVGRect.cpp

Issue 1588993005: Extended error reporting for SVG attribute parsing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: TestExpectations Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/svg/SVGRect.cpp
diff --git a/third_party/WebKit/Source/core/svg/SVGRect.cpp b/third_party/WebKit/Source/core/svg/SVGRect.cpp
index a8f6970264f1f56f3f2d6ee56e91448b72d0d768..8b040dc64e0c3b0093090dadcb2cbf08c0293926 100644
--- a/third_party/WebKit/Source/core/svg/SVGRect.cpp
+++ b/third_party/WebKit/Source/core/svg/SVGRect.cpp
@@ -73,12 +73,12 @@ SVGParsingError SVGRect::setValueAsString(const String& string)
setInvalid();
if (string.isNull())
- return NoError;
+ return SVGStatus::NoError;
if (string.isEmpty()) {
m_value = FloatRect(0.0f, 0.0f, 0.0f, 0.0f);
m_isValid = true;
- return NoError;
+ return SVGStatus::NoError;
}
bool valid;
@@ -91,7 +91,7 @@ SVGParsingError SVGRect::setValueAsString(const String& string)
const UChar* end = ptr + string.length();
valid = parse(ptr, end);
}
- return valid ? NoError : ParsingAttributeFailedError;
+ return valid ? SVGStatus::NoError : SVGStatus::ParsingFailed;
}
String SVGRect::valueAsString() const

Powered by Google App Engine
This is Rietveld 408576698