third_party/WebKit/Source/core/svg/SVGPoint.cpp - Issue 1588993005: Extended error reporting for SVG attribute parsing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGPoint.cpp

Issue 1588993005: Extended error reporting for SVG attribute parsing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: TestExpectations Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/svg/SVGPoint.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGPoint.cpp b/third_party/WebKit/Source/core/svg/SVGPoint.cpp

index 8f0c89420fce9504fb29c8355a758ab686768594..5b0458a6e89199171f176ab6cebfbdbc14c0bac2 100644

--- a/third_party/WebKit/Source/core/svg/SVGPoint.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGPoint.cpp

@@ -84,7 +84,7 @@ SVGParsingError SVGPoint::setValueAsString(const String& string)

{

if (string.isEmpty()) {

m_value = FloatPoint(0.0f, 0.0f);

- return NoError;

+ return SVGStatus::NoError;

}

bool valid;

@@ -97,7 +97,7 @@ SVGParsingError SVGPoint::setValueAsString(const String& string)

const UChar* end = ptr + string.length();

valid = parse(ptr, end);

}

- return valid ? NoError : ParsingAttributeFailedError;

+ return valid ? SVGStatus::NoError : SVGStatus::ParsingFailed;

}

String SVGPoint::valueAsString() const