third_party/WebKit/Source/core/svg/SVGFitToViewBox.cpp - Issue 1588993005: Extended error reporting for SVG attribute parsing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGFitToViewBox.cpp

Issue 1588993005: Extended error reporting for SVG attribute parsing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: TestExpectations Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/svg/SVGFitToViewBox.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGFitToViewBox.cpp b/third_party/WebKit/Source/core/svg/SVGFitToViewBox.cpp

index 9346b9825e98700a5b243b97c5cbc44e26b226d5..d3dbd9d4cad3a7f96fe705ba1b93e4f5a65ea0ec 100644

--- a/third_party/WebKit/Source/core/svg/SVGFitToViewBox.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGFitToViewBox.cpp

@@ -51,8 +51,8 @@ SVGParsingError SVGAnimatedViewBoxRect::setBaseValueAsString(const String& value

{

SVGParsingError parseStatus = baseValue()->setValueAsString(value);

- if (parseStatus == NoError && (baseValue()->width() < 0 || baseValue()->height() < 0)) {

- parseStatus = NegativeValueForbiddenError;

+ if (parseStatus == SVGStatus::NoError && (baseValue()->width() < 0 || baseValue()->height() < 0)) {

+ parseStatus = SVGStatus::NegativeValue;

baseValue()->setInvalid();

}

return parseStatus;