third_party/WebKit/Source/core/svg/SVGEnumeration.cpp - Issue 1588993005: Extended error reporting for SVG attribute parsing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGEnumeration.cpp

Issue 1588993005: Extended error reporting for SVG attribute parsing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: TestExpectations Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/svg/SVGEnumeration.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGEnumeration.cpp b/third_party/WebKit/Source/core/svg/SVGEnumeration.cpp

index ed579acf759a213c14c0cb0031ed9957029b7687..1ee8e41d8222edbf7b0beceafb87e8787aee8b1b 100644

--- a/third_party/WebKit/Source/core/svg/SVGEnumeration.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGEnumeration.cpp

@@ -72,12 +72,12 @@ SVGParsingError SVGEnumerationBase::setValueAsString(const String& string)

ASSERT(entry.first);

m_value = entry.first;

notifyChange();

- return NoError;

+ return SVGStatus::NoError;

}

notifyChange();

- return ParsingAttributeFailedError;

+ return SVGStatus::ExpectedEnumeration;

}

void SVGEnumerationBase::add(PassRefPtrWillBeRawPtr<SVGPropertyBase>, SVGElement*)