third_party/WebKit/Source/core/svg/SVGAnimatedLength.cpp - Issue 1588993005: Extended error reporting for SVG attribute parsing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGAnimatedLength.cpp

Issue 1588993005: Extended error reporting for SVG attribute parsing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: TestExpectations Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/svg/SVGAnimatedLength.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGAnimatedLength.cpp b/third_party/WebKit/Source/core/svg/SVGAnimatedLength.cpp

index 7a2b26a6f1dac61bf5496a2cc817d4aab49dfe2e..766f4bc4e52634edb6f2ab6493751a816be850e4 100644

--- a/third_party/WebKit/Source/core/svg/SVGAnimatedLength.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGAnimatedLength.cpp

@@ -43,10 +43,10 @@ SVGParsingError SVGAnimatedLength::setBaseValueAsString(const String& value)

{

SVGParsingError parseStatus = baseValue()->setValueAsString(value);

- if (parseStatus != NoError)

+ if (parseStatus != SVGStatus::NoError)

baseValue()->newValueSpecifiedUnits(CSSPrimitiveValue::UnitType::UserUnits, 0);

else if (SVGLength::negativeValuesForbiddenForAnimatedLengthAttribute(attributeName()) && baseValue()->valueInSpecifiedUnits() < 0)

- parseStatus = NegativeValueForbiddenError;

+ parseStatus = SVGStatus::NegativeValue;

return parseStatus;

}