third_party/WebKit/Source/core/svg/SVGTransformList.cpp - Issue 1588993005: Extended error reporting for SVG attribute parsing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGTransformList.cpp

Issue 1588993005: Extended error reporting for SVG attribute parsing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add PLATFORM_EXPORT Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/svg/SVGTransformList.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGTransformList.cpp b/third_party/WebKit/Source/core/svg/SVGTransformList.cpp

index 28861bae348674758afc1a018744b62a786b26d2..2785b3b91fd24951c09f47e16b28b7267d12f6c1 100644

--- a/third_party/WebKit/Source/core/svg/SVGTransformList.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGTransformList.cpp

@@ -270,7 +270,7 @@ SVGParsingError SVGTransformList::setValueAsString(const String& value)

{

if (value.isEmpty()) {

clear();

- return NoError;

+ return SVGParseStatus::NoError;

}

bool valid = false;

@@ -286,10 +286,10 @@ SVGParsingError SVGTransformList::setValueAsString(const String& value)

if (!valid) {

clear();

- return ParsingAttributeFailedError;

+ return SVGParseStatus::ParsingFailed;

}

- return NoError;

+ return SVGParseStatus::NoError;

}

PassRefPtrWillBeRawPtr<SVGPropertyBase> SVGTransformList::cloneForAnimation(const String& value) const