Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Unified Diff: third_party/WebKit/Source/core/svg/SVGNumberList.cpp

Issue 1588993005: Extended error reporting for SVG attribute parsing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add PLATFORM_EXPORT Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/svg/SVGNumberList.cpp
diff --git a/third_party/WebKit/Source/core/svg/SVGNumberList.cpp b/third_party/WebKit/Source/core/svg/SVGNumberList.cpp
index 03f74dfda61f4a8472d5f59b41f3e2fde4336a2d..a701cef5eb0227dc1674a0124c5b02a71f8ee2db 100644
--- a/third_party/WebKit/Source/core/svg/SVGNumberList.cpp
+++ b/third_party/WebKit/Source/core/svg/SVGNumberList.cpp
@@ -73,7 +73,7 @@ SVGParsingError SVGNumberList::setValueAsString(const String& value)
{
if (value.isEmpty()) {
clear();
- return NoError;
+ return SVGParseStatus::NoError;
}
bool valid = false;
@@ -90,9 +90,9 @@ SVGParsingError SVGNumberList::setValueAsString(const String& value)
if (!valid) {
// No call to |clear()| here. SVG policy is to use valid items before error.
// Spec: http://www.w3.org/TR/SVG/single-page.html#implnote-ErrorProcessing
- return ParsingAttributeFailedError;
+ return SVGParseStatus::ParsingFailed;
}
- return NoError;
+ return SVGParseStatus::NoError;
}
void SVGNumberList::add(PassRefPtrWillBeRawPtr<SVGPropertyBase> other, SVGElement* contextElement)
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGNumber.cpp ('k') | third_party/WebKit/Source/core/svg/SVGNumberOptionalNumber.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698