Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Unified Diff: third_party/WebKit/Source/core/svg/SVGAnimationElement.cpp

Issue 1588993005: Extended error reporting for SVG attribute parsing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add PLATFORM_EXPORT Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/svg/SVGAnimationElement.cpp
diff --git a/third_party/WebKit/Source/core/svg/SVGAnimationElement.cpp b/third_party/WebKit/Source/core/svg/SVGAnimationElement.cpp
index e16b94c4d61b754a04146ad4728f3bf217682d21..3c60008dc22ff57633a39596fff5cb2a36d31ddf 100644
--- a/third_party/WebKit/Source/core/svg/SVGAnimationElement.cpp
+++ b/third_party/WebKit/Source/core/svg/SVGAnimationElement.cpp
@@ -163,7 +163,7 @@ void SVGAnimationElement::parseAttribute(const QualifiedName& name, const Atomic
{
if (name == SVGNames::valuesAttr) {
if (!parseValues(value, m_values)) {
- reportAttributeParsingError(ParsingAttributeFailedError, name, value);
+ reportAttributeParsingError(SVGParseStatus::ParsingFailed, name, value);
return;
}
updateAnimationMode();
@@ -172,7 +172,7 @@ void SVGAnimationElement::parseAttribute(const QualifiedName& name, const Atomic
if (name == SVGNames::keyTimesAttr) {
if (!parseKeyTimes(value, m_keyTimes, true))
- reportAttributeParsingError(ParsingAttributeFailedError, name, value);
+ reportAttributeParsingError(SVGParseStatus::ParsingFailed, name, value);
return;
}
@@ -181,14 +181,14 @@ void SVGAnimationElement::parseAttribute(const QualifiedName& name, const Atomic
// This is specified to be an animateMotion attribute only but it is simpler to put it here
// where the other timing calculatations are.
if (!parseKeyTimes(value, m_keyPoints, false))
- reportAttributeParsingError(ParsingAttributeFailedError, name, value);
+ reportAttributeParsingError(SVGParseStatus::ParsingFailed, name, value);
}
return;
}
if (name == SVGNames::keySplinesAttr) {
if (!parseKeySplines(value, m_keySplines))
- reportAttributeParsingError(ParsingAttributeFailedError, name, value);
+ reportAttributeParsingError(SVGParseStatus::ParsingFailed, name, value);
return;
}
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGAnimatedLength.cpp ('k') | third_party/WebKit/Source/core/svg/SVGBoolean.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698