Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGPathElement.cpp

Issue 1588993005: Extended error reporting for SVG attribute parsing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add PLATFORM_EXPORT Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2008 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2006, 2008 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2006, 2007 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006, 2007 Rob Buis <buis@kde.org>
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 20 matching lines...) Expand all
31 class SVGAnimatedPathLength final : public SVGAnimatedNumber { 31 class SVGAnimatedPathLength final : public SVGAnimatedNumber {
32 public: 32 public:
33 static PassRefPtrWillBeRawPtr<SVGAnimatedPathLength> create(SVGPathElement* contextElement) 33 static PassRefPtrWillBeRawPtr<SVGAnimatedPathLength> create(SVGPathElement* contextElement)
34 { 34 {
35 return adoptRefWillBeNoop(new SVGAnimatedPathLength(contextElement)); 35 return adoptRefWillBeNoop(new SVGAnimatedPathLength(contextElement));
36 } 36 }
37 37
38 SVGParsingError setBaseValueAsString(const String& value) override 38 SVGParsingError setBaseValueAsString(const String& value) override
39 { 39 {
40 SVGParsingError parseStatus = SVGAnimatedNumber::setBaseValueAsString(va lue); 40 SVGParsingError parseStatus = SVGAnimatedNumber::setBaseValueAsString(va lue);
41 if (parseStatus == NoError && baseValue()->value() < 0) 41 if (parseStatus == SVGParseStatus::NoError && baseValue()->value() < 0)
42 parseStatus = NegativeValueForbiddenError; 42 parseStatus = SVGParseStatus::NegativeValue;
43 return parseStatus; 43 return parseStatus;
44 } 44 }
45 45
46 private: 46 private:
47 explicit SVGAnimatedPathLength(SVGPathElement* contextElement) 47 explicit SVGAnimatedPathLength(SVGPathElement* contextElement)
48 : SVGAnimatedNumber(contextElement, SVGNames::pathLengthAttr, SVGNumber: :create()) 48 : SVGAnimatedNumber(contextElement, SVGNames::pathLengthAttr, SVGNumber: :create())
49 { 49 {
50 } 50 }
51 }; 51 };
52 52
(...skipping 124 matching lines...) Expand 10 before | Expand all | Expand 10 after
177 return InsertionDone; 177 return InsertionDone;
178 } 178 }
179 179
180 void SVGPathElement::removedFrom(ContainerNode* rootParent) 180 void SVGPathElement::removedFrom(ContainerNode* rootParent)
181 { 181 {
182 SVGGeometryElement::removedFrom(rootParent); 182 SVGGeometryElement::removedFrom(rootParent);
183 invalidateMPathDependencies(); 183 invalidateMPathDependencies();
184 } 184 }
185 185
186 } // namespace blink 186 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGPath.cpp ('k') | third_party/WebKit/Source/core/svg/SVGPoint.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698