Extended error reporting for SVG attribute parsing

third_party/WebKit/Source/core/svg/SVGLength.cpp

 /*
  * Copyright (C) 2004, 2005, 2006 Nikolas Zimmermann <zimmermann@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2007 Rob Buis <buis@kde.org>
  * Copyright (C) 2007 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 45 matching lines @@
 PassRefPtrWillBeRawPtr<SVGLength> SVGLength::clone() const
 {
     return adoptRefWillBeNoop(new SVGLength(*this));
 }
 
 PassRefPtrWillBeRawPtr<SVGPropertyBase> SVGLength::cloneForAnimation(const String& value) const
 {
     RefPtrWillBeRawPtr<SVGLength> length = create();
     length->m_unitMode = m_unitMode;
 
-    SVGParsingError status = length->setValueAsString(value);
-    if (status != NoError)
+    if (length->setValueAsString(value) != SVGParseStatus::NoError)
         length->m_value = cssValuePool().createValue(0, CSSPrimitiveValue::UnitType::UserUnits);
 
     return length.release();
 }
 
 bool SVGLength::operator==(const SVGLength& other) const
 {
     return m_unitMode == other.m_unitMode && m_value == other.m_value;
 }
 
@@ skipping 52 matching lines @@
         // Delaying division by 100 as long as possible since it introduces floating point errors.
         result = result / 100;
     }
     return result;
 }
 
 SVGParsingError SVGLength::setValueAsString(const String& string)
 {
     if (string.isEmpty()) {
         m_value = cssValuePool().createValue(0, CSSPrimitiveValue::UnitType::UserUnits);
-        return NoError;
+        return SVGParseStatus::NoError;
     }
 
     CSSParserContext svgParserContext(SVGAttributeMode, 0);
     RefPtrWillBeRawPtr<CSSValue> parsed = CSSParser::parseSingleValue(CSSPropertyX, string, svgParserContext);
     if (!parsed || !parsed->isPrimitiveValue())
-        return ParsingAttributeFailedError;
+        return SVGParseStatus::ParsingFailed;
 
     CSSPrimitiveValue* newValue = toCSSPrimitiveValue(parsed.get());
     // TODO(fs): Enable calc for SVG lengths
     if (newValue->isCalculated() || !isSupportedCSSUnitType(newValue->typeWithCalcResolved()))
-        return ParsingAttributeFailedError;
+        return SVGParseStatus::ParsingFailed;
 
     m_value = newValue;
-    return NoError;
+    return SVGParseStatus::NoError;
 }
 
 String SVGLength::valueAsString() const
 {
     return m_value->customCSSText();
 }
 
 void SVGLength::newValueSpecifiedUnits(CSSPrimitiveValue::UnitType type, float value)
 {
     m_value = CSSPrimitiveValue::create(value, type);
@@ skipping 98 matching lines @@
 
 float SVGLength::calculateDistance(PassRefPtrWillBeRawPtr<SVGPropertyBase> toValue, SVGElement* contextElement)
 {
     SVGLengthContext lengthContext(contextElement);
     RefPtrWillBeRawPtr<SVGLength> toLength = toSVGLength(toValue);
 
     return fabsf(toLength->value(lengthContext) - value(lengthContext));
 }
 
 }