Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGBoolean.cpp

Issue 1588993005: Extended error reporting for SVG attribute parsing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add PLATFORM_EXPORT Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 25 matching lines...) Expand all
36 36
37 String SVGBoolean::valueAsString() const 37 String SVGBoolean::valueAsString() const
38 { 38 {
39 return m_value ? "true" : "false"; 39 return m_value ? "true" : "false";
40 } 40 }
41 41
42 SVGParsingError SVGBoolean::setValueAsString(const String& value) 42 SVGParsingError SVGBoolean::setValueAsString(const String& value)
43 { 43 {
44 if (value == "true") { 44 if (value == "true") {
45 m_value = true; 45 m_value = true;
46 return NoError; 46 return SVGParseStatus::NoError;
47 } 47 }
48 if (value == "false") { 48 if (value == "false") {
49 m_value = false; 49 m_value = false;
50 return NoError; 50 return SVGParseStatus::NoError;
51 } 51 }
52 return ParsingAttributeFailedError; 52 return SVGParseStatus::ExpectedBoolean;
53 } 53 }
54 54
55 void SVGBoolean::add(PassRefPtrWillBeRawPtr<SVGPropertyBase>, SVGElement*) 55 void SVGBoolean::add(PassRefPtrWillBeRawPtr<SVGPropertyBase>, SVGElement*)
56 { 56 {
57 ASSERT_NOT_REACHED(); 57 ASSERT_NOT_REACHED();
58 } 58 }
59 59
60 void SVGBoolean::calculateAnimatedValue(SVGAnimationElement* animationElement, f loat percentage, unsigned repeatCount, PassRefPtrWillBeRawPtr<SVGPropertyBase> f rom, PassRefPtrWillBeRawPtr<SVGPropertyBase> to, PassRefPtrWillBeRawPtr<SVGPrope rtyBase>, SVGElement*) 60 void SVGBoolean::calculateAnimatedValue(SVGAnimationElement* animationElement, f loat percentage, unsigned repeatCount, PassRefPtrWillBeRawPtr<SVGPropertyBase> f rom, PassRefPtrWillBeRawPtr<SVGPropertyBase> to, PassRefPtrWillBeRawPtr<SVGPrope rtyBase>, SVGElement*)
61 { 61 {
62 ASSERT(animationElement); 62 ASSERT(animationElement);
63 bool fromBoolean = animationElement->animationMode() == ToAnimation ? m_valu e : toSVGBoolean(from)->value(); 63 bool fromBoolean = animationElement->animationMode() == ToAnimation ? m_valu e : toSVGBoolean(from)->value();
64 bool toBoolean = toSVGBoolean(to)->value(); 64 bool toBoolean = toSVGBoolean(to)->value();
65 65
66 animationElement->animateDiscreteType<bool>(percentage, fromBoolean, toBoole an, m_value); 66 animationElement->animateDiscreteType<bool>(percentage, fromBoolean, toBoole an, m_value);
67 } 67 }
68 68
69 float SVGBoolean::calculateDistance(PassRefPtrWillBeRawPtr<SVGPropertyBase>, SVG Element*) 69 float SVGBoolean::calculateDistance(PassRefPtrWillBeRawPtr<SVGPropertyBase>, SVG Element*)
70 { 70 {
71 // No paced animations for boolean. 71 // No paced animations for boolean.
72 return -1; 72 return -1;
73 } 73 }
74 74
75 } 75 }
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGAnimationElement.cpp ('k') | third_party/WebKit/Source/core/svg/SVGElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698