Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGAnimatedLength.cpp

Issue 1588993005: Extended error reporting for SVG attribute parsing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add PLATFORM_EXPORT Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 25 matching lines...) Expand all
36 36
37 void SVGAnimatedLength::setDefaultValueAsString(const String& value) 37 void SVGAnimatedLength::setDefaultValueAsString(const String& value)
38 { 38 {
39 baseValue()->setValueAsString(value); 39 baseValue()->setValueAsString(value);
40 } 40 }
41 41
42 SVGParsingError SVGAnimatedLength::setBaseValueAsString(const String& value) 42 SVGParsingError SVGAnimatedLength::setBaseValueAsString(const String& value)
43 { 43 {
44 SVGParsingError parseStatus = baseValue()->setValueAsString(value); 44 SVGParsingError parseStatus = baseValue()->setValueAsString(value);
45 45
46 if (parseStatus != NoError) 46 if (parseStatus != SVGParseStatus::NoError)
47 baseValue()->newValueSpecifiedUnits(CSSPrimitiveValue::UnitType::UserUni ts, 0); 47 baseValue()->newValueSpecifiedUnits(CSSPrimitiveValue::UnitType::UserUni ts, 0);
48 else if (SVGLength::negativeValuesForbiddenForAnimatedLengthAttribute(attrib uteName()) && baseValue()->valueInSpecifiedUnits() < 0) 48 else if (SVGLength::negativeValuesForbiddenForAnimatedLengthAttribute(attrib uteName()) && baseValue()->valueInSpecifiedUnits() < 0)
49 parseStatus = NegativeValueForbiddenError; 49 parseStatus = SVGParseStatus::NegativeValue;
50 50
51 return parseStatus; 51 return parseStatus;
52 } 52 }
53 53
54 } 54 }
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGAngleTearOff.cpp ('k') | third_party/WebKit/Source/core/svg/SVGAnimationElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698