components/signin/core/browser/account_info.cc - Issue 1588913002: Fix AccountInfo uninitialized memory issues.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/signin/core/browser/account_info.cc

Issue 1588913002: Fix AccountInfo uninitialized memory issues. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/signin/core/browser/account_info.cc

diff --git a/components/signin/core/browser/account_info.cc b/components/signin/core/browser/account_info.cc

index 1392c284329ba40373c087baca931c2bf79a7193..6dd4495dd4d9a1fbed21011e3b8fa9f08c832fed 100644

--- a/components/signin/core/browser/account_info.cc

+++ b/components/signin/core/browser/account_info.cc

@@ -21,7 +21,16 @@ bool UpdateField(bool* field, bool new_value) {

}

-AccountInfo::AccountInfo() {}

+AccountInfo::AccountInfo()

+ : account_id(),

+ gaia(),

+ email(),

+ full_name(),

+ given_name(),

+ hosted_domain(),

+ locale(),

+ picture_url(),

+ is_child_account() {}

Roger Tawa OOO till Jul 10th 2016/01/14 14:40:08 nit: could you explicitly set the default value to

bzanotti 2016/01/14 14:42:35 Done.

AccountInfo::~AccountInfo() {}

bool AccountInfo::IsValid() const {

« no previous file with comments | « no previous file | components/signin/core/browser/account_info_unittest.cc » ('j') | no next file with comments »