Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1588853002: Removal of ash related code from chrome_native_app_window_views_win (Closed)

Created:
4 years, 11 months ago by wierichs
Modified:
4 years, 11 months ago
Reviewers:
benwells, scottmg
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removal of ash related code from chrome_native_app_window_views_win BUG=558054 Committed: https://crrev.com/b6ae4344fd63794ce27f86d54c762119912bbfb0 Cr-Commit-Position: refs/heads/master@{#369361}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -22 lines) Patch
M chrome/browser/ui/views/apps/chrome_native_app_window_views_win.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/apps/chrome_native_app_window_views_win.cc View 4 chunks +1 line, -20 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
wierichs
4 years, 11 months ago (2016-01-14 02:57:57 UTC) #2
benwells
lgtm if ash is gone from windows...
4 years, 11 months ago (2016-01-14 04:39:42 UTC) #4
wierichs
4 years, 11 months ago (2016-01-14 04:41:16 UTC) #6
scottmg
Yeah, not quite gone, but actively going. lgtm.
4 years, 11 months ago (2016-01-14 05:10:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1588853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1588853002/1
4 years, 11 months ago (2016-01-14 06:21:21 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-14 07:33:40 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 07:35:15 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b6ae4344fd63794ce27f86d54c762119912bbfb0
Cr-Commit-Position: refs/heads/master@{#369361}

Powered by Google App Engine
This is Rietveld 408576698