[heap] Properly adjust live bytes for pages where we abort evacaution

[heap] Properly adjust live bytes for pages where we abort evacaution

BUG=chromium:524425
LOG=N

Committed: https://crrev.com/f501373dc738f1e83cfc51a46b46b5daeb757a0d
Cr-Commit-Position: refs/heads/master@{#33302}

[Michael Lippautz, 2016-01-14 15:32:48]

mlippautz@chromium.org changed reviewers:
+ ulan@chromium.org

[Michael Lippautz, 2016-01-14 15:32:49]

PTAL

Not really an issue right now but we might as well keep the counter correct in
this rare case.

[Michael Lippautz, 2016-01-14 15:33:26]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-14 15:33:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1588823003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1588823003/1

[commit-bot: I haz the power, 2016-01-14 15:45:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-14 15:46:00]

Dry run: Try jobs failed on following builders:
  v8_linux_arm_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/12389)

[ulan, 2016-01-14 15:46:38]

https://codereview.chromium.org/1588823003/diff/1/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):

https://codereview.chromium.org/1588823003/diff/1/src/heap/mark-compact.cc#ne...
src/heap/mark-compact.cc:3513: LiveObjectIterator<kBlackObjects> it2(page);
Let's move this code into a separate function named something like
RecomputeLiveBytes().

https://codereview.chromium.org/1588823003/diff/1/src/heap/mark-compact.cc#ne...
src/heap/mark-compact.cc:3519: page->IncrementLiveBytes(new_live_size -
page->LiveBytes());
I think adding new page->SetLiveBytes(new_live_size) would be better.

Otherwise, we are passing negative number to IncrementLiveBytes.

[Michael Lippautz, 2016-01-14 16:01:15]

Patchset #2 (id:20001) has been deleted

[Michael Lippautz, 2016-01-14 16:01:46]

I removed the DCHECK because it would actually require RecomputeLiveBytes to
have "sane" (outdated) live bytes information. 

(The failure was because of checking < instead of <=. If we fail at evacuating
the very first objects than new_live_bytes == old_lives_bytes).

https://codereview.chromium.org/1588823003/diff/1/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):

https://codereview.chromium.org/1588823003/diff/1/src/heap/mark-compact.cc#ne...
src/heap/mark-compact.cc:3513: LiveObjectIterator<kBlackObjects> it2(page);
On 2016/01/14 15:46:38, ulan wrote:
> Let's move this code into a separate function named something like
> RecomputeLiveBytes().

RecomputeLiveBytes it is.

https://codereview.chromium.org/1588823003/diff/1/src/heap/mark-compact.cc#ne...
src/heap/mark-compact.cc:3519: page->IncrementLiveBytes(new_live_size -
page->LiveBytes());
On 2016/01/14 15:46:38, ulan wrote:
> I think adding new page->SetLiveBytes(new_live_size) would be better.
> 
> Otherwise, we are passing negative number to IncrementLiveBytes.

SetLiveBytes() it is.

[Michael Lippautz, 2016-01-14 16:15:06]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-14 16:15:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1588823003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1588823003/40001

[ulan, 2016-01-14 16:17:38]

lgtm

[commit-bot: I haz the power, 2016-01-14 16:39:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-14 16:39:51]

Dry run: This issue passed the CQ dry run.

[Michael Lippautz, 2016-01-14 16:59:52]

The CQ bit was checked by mlippautz@chromium.org

[commit-bot: I haz the power, 2016-01-14 17:00:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1588823003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1588823003/40001

[commit-bot: I haz the power, 2016-01-14 17:03:31]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-01-14 17:04:23]

Description was changed from

==========
[heap] Properly adjust live bytes for pages where we abort evacaution

BUG=chromium:524425
LOG=N
==========

to

==========
[heap] Properly adjust live bytes for pages where we abort evacaution

BUG=chromium:524425
LOG=N

Committed: https://crrev.com/f501373dc738f1e83cfc51a46b46b5daeb757a0d
Cr-Commit-Position: refs/heads/master@{#33302}
==========

[commit-bot: I haz the power, 2016-01-14 17:04:24]

Patchset 2 (id:??) landed as
https://crrev.com/f501373dc738f1e83cfc51a46b46b5daeb757a0d
Cr-Commit-Position: refs/heads/master@{#33302}