dart2js cps: Avoid comparing boolean values to boolean constants.

dart2js cps: Avoid comparing boolean values to boolean constants.

E.g. (x === true) can be replaced with x if x is a boolean.

Box2D has some code where this happens.

BUG=
R=kmillikin@google.com, sra@google.com

Committed: https://github.com/dart-lang/sdk/commit/dd8ba75909d2ba36d8cb79b217e00604c942ba02

Committed: https://github.com/dart-lang/sdk/commit/1b9a7e0be56853c2c59e452f9255669c055f9ac0

[asgerf, 2016-01-14 01:21:53]

asgerf@google.com changed reviewers:
+ kmillikin@google.com, sra@google.com

[Kevin Millikin (Google), 2016-01-14 01:26:45]

LGTM.

https://codereview.chromium.org/1588813002/diff/20001/pkg/compiler/lib/src/cp...
File pkg/compiler/lib/src/cps_ir/type_propagation.dart (right):

https://codereview.chromium.org/1588813002/diff/20001/pkg/compiler/lib/src/cp...
pkg/compiler/lib/src/cps_ir/type_propagation.dart:2130: default:
This is disconcerting.

[asgerf, 2016-01-14 01:43:15]

https://codereview.chromium.org/1588813002/diff/20001/pkg/compiler/lib/src/cp...
File pkg/compiler/lib/src/cps_ir/type_propagation.dart (right):

https://codereview.chromium.org/1588813002/diff/20001/pkg/compiler/lib/src/cp...
pkg/compiler/lib/src/cps_ir/type_propagation.dart:2130: default:
On 2016/01/14 01:26:45, Kevin Millikin (Google) wrote:
> This is disconcerting.

It is required unless we add cases for all builtin operators.

[Kevin Millikin (Google), 2016-01-14 01:57:40]

On 2016/01/14 01:43:15, asgerf wrote:
>
https://codereview.chromium.org/1588813002/diff/20001/pkg/compiler/lib/src/cp...
> File pkg/compiler/lib/src/cps_ir/type_propagation.dart (right):
> 
>
https://codereview.chromium.org/1588813002/diff/20001/pkg/compiler/lib/src/cp...
> pkg/compiler/lib/src/cps_ir/type_propagation.dart:2130: default:
> On 2016/01/14 01:26:45, Kevin Millikin (Google) wrote:
> > This is disconcerting.
> 
> It is required unless we add cases for all builtin operators.

I didn't even know that (the VM doesn't warn)!

I guess it's disconcerting to me that the spec treats 'enum Bool { FALSE, TRUE }
any differently than bool.

[asgerf, 2016-01-14 18:47:42]

PTAL.

There was a potential issue with the way == calls get rewritten to identical and
then to strict/loose equality. We now trigger reprocessing of the term after
rewriting identical -> equality to ensure we don't end up with identical(x,
false).

[sra1, 2016-01-14 19:07:18]

lgtm

[asgerf, 2016-01-14 20:28:18]

Description was changed from

==========
dart2js cps: Avoid comparing boolean values to boolean constants.

E.g. (x === true) can be replaced with x if x is a boolean.

Box2D has some code where this happens.

BUG=
==========

to

==========
dart2js cps: Avoid comparing boolean values to boolean constants.

E.g. (x === true) can be replaced with x if x is a boolean.

Box2D has some code where this happens.

BUG=
R=kmillikin@google.com, sra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/dd8ba75909d2ba36d8cb79b217e00604c942ba02
==========

[asgerf, 2016-01-14 20:28:19]

Committed patchset #3 (id:40001) manually as
dd8ba75909d2ba36d8cb79b217e00604c942ba02 (presubmit successful).

[asgerf, 2016-01-14 21:01:33]

Description was changed from

==========
dart2js cps: Avoid comparing boolean values to boolean constants.

E.g. (x === true) can be replaced with x if x is a boolean.

Box2D has some code where this happens.

BUG=
R=kmillikin@google.com, sra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/dd8ba75909d2ba36d8cb79b217e00604c942ba02
==========

to

==========
dart2js cps: Avoid comparing boolean values to boolean constants.

E.g. (x === true) can be replaced with x if x is a boolean.

Box2D has some code where this happens.

BUG=
R=kmillikin@google.com, sra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/dd8ba75909d2ba36d8cb79b217e00604c942ba02

Committed:
https://github.com/dart-lang/sdk/commit/1b9a7e0be56853c2c59e452f9255669c055f9ac0
==========

[asgerf, 2016-01-14 21:01:34]

Committed patchset #4 (id:60001) manually as
1b9a7e0be56853c2c59e452f9255669c055f9ac0 (presubmit successful).