scripts/slave/recipe_modules/chromium_tests/bot_config_and_test_db.py - Issue 1588793002: Support variable substitution and tryserver- and waterfall-only cmd line args.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/chromium_tests/bot_config_and_test_db.py

Issue 1588793002: Support variable substitution and tryserver- and waterfall-only cmd line args. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Addressed review feedback. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipe_modules/chromium_tests/api.py ('k') | scripts/slave/recipe_modules/chromium_tests/steps.py » ('j') | scripts/slave/recipe_modules/chromium_tests/steps.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipe_modules/chromium_tests/bot_config_and_test_db.py

diff --git a/scripts/slave/recipe_modules/chromium_tests/bot_config_and_test_db.py b/scripts/slave/recipe_modules/chromium_tests/bot_config_and_test_db.py

index d2dd4cff9183c09e22be15a22dc418ad325a7056..59e88e4711590d7ac6a02c71ac6dcbbeb656ee49 100644

--- a/scripts/slave/recipe_modules/chromium_tests/bot_config_and_test_db.py

+++ b/scripts/slave/recipe_modules/chromium_tests/bot_config_and_test_db.py

@@ -70,7 +70,7 @@ class BotConfig(object):

return {}

return chromium_tests_api.read_test_spec(chromium_tests_api.m, test_spec_file)

- def initialize_bot_db(self, chromium_tests_api, bot_db):

+ def initialize_bot_db(self, chromium_tests_api, bot_db, bot_update_step):

# TODO(phajdan.jr): Make this work for more than 1 bot.

assert len(self._bot_ids) == 1

@@ -103,7 +103,8 @@ class BotConfig(object):

# Above should remove the need to get bot_config and buildername

# in this method.

bot_config.get('enable_swarming', False),

- scripts_compile_targets, builder_dict.get('test_generators', [])

+ scripts_compile_targets, builder_dict.get('test_generators', []),

+ bot_update_step

))

bot_db._add_master_dict_and_test_spec(