Support variable substitution and tryserver- and waterfall-only cmd line args.

scripts/slave/recipes/chromium_trybot.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import collections
 
 from recipe_engine.types import freeze
 
 DEPS = [
   'amp',
@@ skipping 199 matching lines @@
 
   # TODO(sergiyb): This is a temporary hack to run GPU tests on tryserver
   # only. This should be removed when we will convert chromium.gpu waterfall
   # to swarming and be able to replicate the tests to tryserver automatically.
   master = api.properties['mastername']
   builder = api.properties['buildername']
   enable_gpu_tests = builder in CHROMIUM_GPU_DIMENSION_SETS.get(master, {})
 
   bot_config_object = api.chromium_tests.create_generalized_bot_config_object(
       bot_config['bot_ids'])
+  api.chromium_tests.set_precommit_mode()
   api.chromium_tests.configure_build(
       bot_config_object, override_bot_type='builder_tester')
 
   api.chromium_tests.configure_swarming('chromium', precommit=True)
 
   api.chromium.apply_config('trybot_flavor')
   if enable_gpu_tests:
     api.chromium.apply_config('archive_gpu_tests')
     api.chromium.apply_config('chrome_with_codecs')
 
@@ skipping 239 matching lines @@
         },
     })) +
     suppress_analyze() +
     api.override_step_data('base_unittests (with patch)',
                            canned_test(passing=False)) +
     api.override_step_data('base_unittests (without patch)',
                            api.test_utils.raw_gtest_output(None, retcode=1))
   )
 
   yield (
+    api.test('dynamic_isolated_script_test_with_args_on_trybot') +
+    props(extra_swarmed_tests=['telemetry_gpu_unittests']) +
+    api.platform.name('linux') +
+    api.override_step_data('read test spec', api.json.output({
+        'Linux Tests': {
+            'isolated_scripts': [
+                {
+                  'isolate_name': 'telemetry_gpu_unittests',
+                  'name': 'telemetry_gpu_unittests',
+                  'args': ['--correct-common-arg'],
+                  'non_precommit_args': [
+                    '--SHOULD-NOT-BE-PRESENT-DURING-THE-RUN'
+                  ],
+                  'precommit_args': [
+                    '--these-args-should-be-present',
+                    '--test-machine-name=\"${buildername}\"',
+                    '--build-revision=\"${got_revision}\"',
+                  ],
+                  'swarming': {'can_use_on_swarming_builders': True},
+                },
+            ],
+        },
+    })) +
+    suppress_analyze() +
+    api.override_step_data(
+        'telemetry_gpu_unittests (with patch)',
+        api.test_utils.canned_isolated_script_output(
+            passing=True, is_win=False, swarming=True))
+  )
+
+  yield (
     api.test('swarming_trigger_failure') +
     props() +
     api.platform.name('linux') +
     api.override_step_data('read test spec', api.json.output({
         'Linux Tests': {
             'gtest_tests': [
                 {
                   'test': 'base_unittests',
                   'swarming': {'can_use_on_swarming_builders': True},
                 },
@@ skipping 579 matching lines @@
     props(mastername='tryserver.v8',
           buildername='v8_linux_blink_rel',
           patch_project='v8') +
     api.platform.name('linux') +
     suppress_analyze(more_exclusions=['v8/f.*']) +
     api.override_step_data('webkit_tests (with patch)',
         api.test_utils.canned_test_output(passing=False)) +
     api.override_step_data('webkit_tests (without patch)',
         api.test_utils.canned_test_output(passing=True, minimal=True))
   )