Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Side by Side Diff: scripts/slave/recipes/chromium.py

Issue 1588793002: Support variable substitution and tryserver- and waterfall-only cmd line args. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Addressed review feedback. Revised tests. Rebased. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 DEPS = [ 5 DEPS = [
6 'adb', 6 'adb',
7 'amp', 7 'amp',
8 'bisect_tester', 8 'bisect_tester',
9 'bot_update', 9 'bot_update',
10 'chromium', 10 'chromium',
(...skipping 273 matching lines...) Expand 10 before | Expand all | Expand 10 after
284 parent_buildername='Linux Builder') + 284 parent_buildername='Linux Builder') +
285 api.properties(swarm_hashes={ 285 api.properties(swarm_hashes={
286 'telemetry_gpu_unittests': 'eeeeeeeeeeeeeeeeeeeeeeeeeeeeee', 286 'telemetry_gpu_unittests': 'eeeeeeeeeeeeeeeeeeeeeeeeeeeeee',
287 }) + 287 }) +
288 api.platform('linux', 64) + 288 api.platform('linux', 64) +
289 api.override_step_data('read test spec', api.json.output({ 289 api.override_step_data('read test spec', api.json.output({
290 'Linux Tests': { 290 'Linux Tests': {
291 'isolated_scripts': [ 291 'isolated_scripts': [
292 { 292 {
293 'isolate_name': 'telemetry_gpu_unittests', 293 'isolate_name': 'telemetry_gpu_unittests',
294 'name': 'telemetry_gpu_unittests' 294 'name': 'telemetry_gpu_unittests',
295 'args': ['--correct-common-arg'],
296 'precommit_args': ['--SHOULD-NOT-BE-PRESENT-DURING-THE-RUN'],
297 'non_precommit_args': [
298 '--these-args-should-be-present',
299 '--test-machine-name=\"${buildername}\"',
300 '--build-revision=\"${got_revision}\"',
301 ],
295 }, 302 },
296 ], 303 ],
297 }, 304 },
298 })) 305 }))
299 ) 306 )
300 307
301 yield ( 308 yield (
302 api.test('build_dynamic_isolated_script_test_compile_target_overriden') + 309 api.test('build_dynamic_isolated_script_test_compile_target_overriden') +
303 api.properties.generic(mastername='chromium.linux', 310 api.properties.generic(mastername='chromium.linux',
304 buildername='Linux Builder') + 311 buildername='Linux Builder') +
(...skipping 630 matching lines...) Expand 10 before | Expand all | Expand 10 after
935 api.test('chromium_linux_Android_Tests_logcat_upload_timeout') + 942 api.test('chromium_linux_Android_Tests_logcat_upload_timeout') +
936 api.properties( 943 api.properties(
937 mastername='chromium.linux', 944 mastername='chromium.linux',
938 buildername='Android Tests', 945 buildername='Android Tests',
939 slavename='build1-a1', 946 slavename='build1-a1',
940 buildnumber='77457', 947 buildnumber='77457',
941 parent_buildername='Android Builder', 948 parent_buildername='Android Builder',
942 ) + 949 ) +
943 api.override_step_data('gsutil upload', retcode=-2001) 950 api.override_step_data('gsutil upload', retcode=-2001)
944 ) 951 )
OLDNEW
« no previous file with comments | « scripts/slave/recipes/android/perf.py ('k') | scripts/slave/recipes/chromium.expected/dynamic_isolated_script_test.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698