Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Side by Side Diff: scripts/slave/recipes/chromium_trybot.py

Issue 1588793002: Support variable substitution and tryserver- and waterfall-only cmd line args. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import collections 5 import collections
6 6
7 from recipe_engine.types import freeze 7 from recipe_engine.types import freeze
8 8
9 DEPS = [ 9 DEPS = [
10 'amp', 10 'amp',
(...skipping 199 matching lines...) Expand 10 before | Expand all | Expand 10 after
210 210
211 # TODO(sergiyb): This is a temporary hack to run GPU tests on tryserver 211 # TODO(sergiyb): This is a temporary hack to run GPU tests on tryserver
212 # only. This should be removed when we will convert chromium.gpu waterfall 212 # only. This should be removed when we will convert chromium.gpu waterfall
213 # to swarming and be able to replicate the tests to tryserver automatically. 213 # to swarming and be able to replicate the tests to tryserver automatically.
214 master = api.properties['mastername'] 214 master = api.properties['mastername']
215 builder = api.properties['buildername'] 215 builder = api.properties['buildername']
216 enable_gpu_tests = builder in CHROMIUM_GPU_DIMENSION_SETS.get(master, {}) 216 enable_gpu_tests = builder in CHROMIUM_GPU_DIMENSION_SETS.get(master, {})
217 217
218 bot_config_object = api.chromium_tests.create_bot_config_object( 218 bot_config_object = api.chromium_tests.create_bot_config_object(
219 bot_config['mastername'], bot_config['buildername']) 219 bot_config['mastername'], bot_config['buildername'])
220 api.chromium_tests.set_precommit_mode()
220 api.chromium_tests.configure_build( 221 api.chromium_tests.configure_build(
221 bot_config_object, override_bot_type='builder_tester') 222 bot_config_object, override_bot_type='builder_tester')
222 223
223 api.chromium_tests.configure_swarming('chromium', precommit=True) 224 api.chromium_tests.configure_swarming('chromium', precommit=True)
224 225
225 api.chromium.apply_config('trybot_flavor') 226 api.chromium.apply_config('trybot_flavor')
226 if enable_gpu_tests: 227 if enable_gpu_tests:
227 api.chromium.apply_config('archive_gpu_tests') 228 api.chromium.apply_config('archive_gpu_tests')
228 api.chromium.apply_config('chrome_with_codecs') 229 api.chromium.apply_config('chrome_with_codecs')
229 230
(...skipping 256 matching lines...) Expand 10 before | Expand all | Expand 10 after
486 }, 487 },
487 })) + 488 })) +
488 suppress_analyze() + 489 suppress_analyze() +
489 api.override_step_data('base_unittests (with patch)', 490 api.override_step_data('base_unittests (with patch)',
490 canned_test(passing=False)) + 491 canned_test(passing=False)) +
491 api.override_step_data('base_unittests (without patch)', 492 api.override_step_data('base_unittests (without patch)',
492 api.test_utils.raw_gtest_output(None, retcode=1)) 493 api.test_utils.raw_gtest_output(None, retcode=1))
493 ) 494 )
494 495
495 yield ( 496 yield (
497 api.test('dynamic_gtest_with_args_on_trybot') +
498 props() +
499 api.platform.name('linux') +
500 api.override_step_data('read test spec', api.json.output({
501 'Linux Tests': {
502 'gtest_tests': [
503 {
504 'test': 'base_unittests',
505 'args': ['--correct-common-arg'],
506 'non_precommit_args': ['--THIS-ARG-SHOULD-NOT-BE-PRESENT'],
507 'precommit_args': [
508 '--these-args-should-be-present',
509 '--mastername=\"${master_name}\"',
510 '--buildername=\"${builder_name}\"',
511 '--buildrevision=\"${build_revision}\"',
512 ],
513 },
514 ],
515 },
516 })) +
517 suppress_analyze()
518 )
519
520 yield (
496 api.test('swarming_trigger_failure') + 521 api.test('swarming_trigger_failure') +
497 props() + 522 props() +
498 api.platform.name('linux') + 523 api.platform.name('linux') +
499 api.override_step_data('read test spec', api.json.output({ 524 api.override_step_data('read test spec', api.json.output({
500 'Linux Tests': { 525 'Linux Tests': {
501 'gtest_tests': [ 526 'gtest_tests': [
502 { 527 {
503 'test': 'base_unittests', 528 'test': 'base_unittests',
504 'swarming': {'can_use_on_swarming_builders': True}, 529 'swarming': {'can_use_on_swarming_builders': True},
505 }, 530 },
(...skipping 566 matching lines...) Expand 10 before | Expand all | Expand 10 after
1072 api.test_utils.canned_test_output(passing=True)) 1097 api.test_utils.canned_test_output(passing=True))
1073 ) 1098 )
1074 1099
1075 yield ( 1100 yield (
1076 api.test('use_v8_patch_on_blink_trybot') + 1101 api.test('use_v8_patch_on_blink_trybot') +
1077 props(mastername='tryserver.blink', 1102 props(mastername='tryserver.blink',
1078 buildername='mac_blink_rel', 1103 buildername='mac_blink_rel',
1079 patch_project='v8') + 1104 patch_project='v8') +
1080 api.platform.name('mac') 1105 api.platform.name('mac')
1081 ) 1106 )
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698