Do not include resolved_names_ and loaded_scripts_ consistently in both the full and script snapsho…

Do not include resolved_names_ and loaded_scripts_ consistently in both the full and script snapshots. Initialize the resolved names cache correctly in both cases when reading the snapshot.

This reduces the isolate snapshot size from 255324 to 249714.

R=hausner@google.com

Committed: https://github.com/dart-lang/sdk/commit/8359b9e20c42649567e9375b3ca694cf28767b62

[siva, 2016-01-13 23:44:34]

asiva@google.com changed reviewers:
+ hausner@google.com

[hausner, 2016-01-13 23:58:11]

LGTM w/suggestion.

https://codereview.chromium.org/1588783002/diff/20001/runtime/vm/raw_object_s...
File runtime/vm/raw_object_snapshot.cc (right):

https://codereview.chromium.org/1588783002/diff/20001/runtime/vm/raw_object_s...
runtime/vm/raw_object_snapshot.cc:1170: // We do not write the loaded_scripts_
and resolved_names_ caches to the
Another option could be to call Library::InvalidateResolvedNamesCache() here and
just write out the emptied names cache to the snapshot. No special case is
needed then in the read code above, and in InitResolvedNamesCache(). There is a
small price in snapshot size, but less complexity in the code.

[siva, 2016-01-14 00:03:31]

https://codereview.chromium.org/1588783002/diff/20001/runtime/vm/raw_object_s...
File runtime/vm/raw_object_snapshot.cc (right):

https://codereview.chromium.org/1588783002/diff/20001/runtime/vm/raw_object_s...
runtime/vm/raw_object_snapshot.cc:1170: // We do not write the loaded_scripts_
and resolved_names_ caches to the
On 2016/01/13 23:58:11, hausner wrote:
> Another option could be to call Library::InvalidateResolvedNamesCache() here
and
> just write out the emptied names cache to the snapshot. No special case is
> needed then in the read code above, and in InitResolvedNamesCache(). There is
a
> small price in snapshot size, but less complexity in the code.

True, I tried that initially but this piece of code runs in a NoHandleScope and
the function InvalidateResolvedNamesCache requires a Library handle.

[siva, 2016-01-14 00:42:31]

Description was changed from

==========
Do not include resolved_names_ and loaded_scripts_ consistently in both the full
and script snapshots. Initialize the resolved names cache correctly in both
cases when reading the snapshot.

This reduces the isolate snapshot size from 255324 to 249714.
==========

to

==========
Do not include resolved_names_ and loaded_scripts_ consistently in both the full
and script snapshots. Initialize the resolved names cache correctly in both
cases when reading the snapshot.

This reduces the isolate snapshot size from 255324 to 249714.

R=hausner@google.com

Committed:
https://github.com/dart-lang/sdk/commit/8359b9e20c42649567e9375b3ca694cf28767b62
==========

[siva, 2016-01-14 00:42:32]

Committed patchset #2 (id:20001) manually as
8359b9e20c42649567e9375b3ca694cf28767b62 (presubmit successful).