Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 1588733008: dart2js: Default to an empty set instead of null (Closed)

Created:
4 years, 11 months ago by asgerf
Modified:
4 years, 11 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: Default to an empty set instead of null The set of interceptor classes that can respond to a given selector depends on which classes are considered instantiated by resolution. It can therefore be empty even for intercepted selectors. Do not surprise the caller by returning null. BUG= R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/f123fa568de20bf6272bce8bc2456b1f30cc77e5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M pkg/compiler/lib/src/js_backend/backend.dart View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
asgerf
A crash can be produced by disabling type propagation and then run on: class Foo ...
4 years, 11 months ago (2016-01-15 02:07:36 UTC) #5
Siggi Cherem (dart-lang)
lgtm
4 years, 11 months ago (2016-01-15 02:24:06 UTC) #6
asgerf
4 years, 11 months ago (2016-01-15 17:29:14 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f123fa568de20bf6272bce8bc2456b1f30cc77e5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698