Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 1588733003: test cast for bug_361 (Closed)

Created:
4 years, 11 months ago by Tom Sepez
Modified:
4 years, 11 months ago
Reviewers:
Lei Zhang, Tom Bergan
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add more tests and expected results file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -0 lines) Patch
A testing/resources/javascript/bug_361.in View 1 1 chunk +91 lines, -0 lines 0 comments Download
A testing/resources/javascript/bug_361_expected.txt View 1 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
Tom Sepez
Manually-created testcase, alas doesn't open on reader.
4 years, 11 months ago (2016-01-13 22:44:48 UTC) #2
Lei Zhang
On 2016/01/13 22:44:48, Tom Sepez wrote: > Manually-created testcase, alas doesn't open on reader. That's ...
4 years, 11 months ago (2016-01-13 22:47:59 UTC) #3
Tom Bergan
Does there need to be an _expected.txt file as well?
4 years, 11 months ago (2016-01-13 23:26:01 UTC) #4
Tom Sepez
On 2016/01/13 23:26:01, Tom Bergan wrote: > Does there need to be an _expected.txt file ...
4 years, 11 months ago (2016-01-13 23:33:55 UTC) #5
Tom Sepez
On 2016/01/13 22:47:59, Lei Zhang wrote: > On 2016/01/13 22:44:48, Tom Sepez wrote: > > ...
4 years, 11 months ago (2016-01-13 23:34:26 UTC) #6
Tom Bergan
lgtm
4 years, 11 months ago (2016-01-13 23:35:21 UTC) #7
Tom Sepez
Pls review
4 years, 11 months ago (2016-01-13 23:36:10 UTC) #8
Lei Zhang
lgtm
4 years, 11 months ago (2016-01-13 23:36:28 UTC) #9
Tom Sepez
4 years, 11 months ago (2016-01-13 23:42:30 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
15367cbbb7b8bea2549212b3c9c1f01727c6ccb5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698