Issue 158873006: Revert "Traitify ParserBase and move functions there."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 158873006: Revert "Traitify ParserBase and move functions there." (Closed)

Created:
6 years, 10 months ago by marja

Modified:
6 years, 10 months ago

Reviewers:

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Revert "Traitify ParserBase and move functions there." This reverts commit r19230. Reason: Build failures on NaCl. BUG= TBR=marja@chromium.org,mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19234

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+673 lines, -643 lines)			Patch
M	src/parser.h	View	7 chunks	+32 lines, -38 lines	0 comments	Download
M	src/parser.cc	View	22 chunks	+274 lines, -98 lines	0 comments	Download
M	src/preparser.h	View	12 chunks	+193 lines, -418 lines	0 comments	Download
M	src/preparser.cc	View	14 chunks	+172 lines, -86 lines	0 comments	Download
M	test/cctest/test-parsing.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download

Total messages: 1 (0 generated)

marja

6 years, 10 months ago (2014-02-10 16:21:19 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r19234 (tree was closed).