Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1588723002: Allow super type to be malformed (fixes issue 25426). (Closed)

Created:
4 years, 11 months ago by regis
Modified:
4 years, 11 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Allow super type to be malformed (fixes issue 25426). Update co19 status file. Committed: https://github.com/dart-lang/sdk/commit/096843b6481048dd71fa98dc547b0543d057604f

Patch Set 1 #

Patch Set 2 : safer alternative fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M runtime/vm/class_finalizer.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
regis
4 years, 11 months ago (2016-01-13 21:22:48 UTC) #2
regis
This may be a safer way to fix this issue, by reporting the error earlier ...
4 years, 11 months ago (2016-01-13 22:39:59 UTC) #3
regis
On 2016/01/13 22:39:59, regis wrote: > This may be a safer way to fix this ...
4 years, 11 months ago (2016-01-19 23:41:46 UTC) #4
regis
Committed patchset #2 (id:20001) manually as 096843b6481048dd71fa98dc547b0543d057604f (presubmit successful).
4 years, 11 months ago (2016-01-19 23:45:34 UTC) #6
Ivan Posva
4 years, 11 months ago (2016-01-20 07:47:18 UTC) #7
Message was sent while issue was closed.
LGTM -ip

Powered by Google App Engine
This is Rietveld 408576698