Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(750)

Issue 1588703002: Slight clean-up of the bookmark bubble. (Closed)

Created:
4 years, 11 months ago by Avi (use Gerrit)
Modified:
4 years, 11 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, tfarina, noyau+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Slight clean-up of the bookmark bubble. There's no need to make a subclass for this purpose; a single NSObject that is used everywhere will do fine. Committed: https://crrev.com/5bc97f928482c36622b504c4bcc2fc997c00c6b3 Cr-Commit-Position: refs/heads/master@{#369318}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -17 lines) Patch
M chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm View 5 chunks +6 lines, -17 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1588703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1588703002/1
4 years, 11 months ago (2016-01-13 20:30:46 UTC) #2
Avi (use Gerrit)
4 years, 11 months ago (2016-01-13 20:43:05 UTC) #4
Robert Sesek
lgtm
4 years, 11 months ago (2016-01-13 21:35:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1588703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1588703002/1
4 years, 11 months ago (2016-01-13 21:54:11 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_daisy_chromium_compile_only_ng on ...
4 years, 11 months ago (2016-01-13 23:39:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1588703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1588703002/1
4 years, 11 months ago (2016-01-14 03:19:32 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-14 03:57:07 UTC) #13
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 03:59:05 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5bc97f928482c36622b504c4bcc2fc997c00c6b3
Cr-Commit-Position: refs/heads/master@{#369318}

Powered by Google App Engine
This is Rietveld 408576698