Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Side by Side Diff: build/config/compiler/compiler.gni

Issue 1588673003: Disable debug information when use_order_profiling=true (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix gyp Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni")
5 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
6 import("//build/config/sanitizers/sanitizers.gni") 7 import("//build/config/sanitizers/sanitizers.gni")
7 8
8 declare_args() { 9 declare_args() {
9 # How many symbols to include in the build. This affects the performance of 10 # How many symbols to include in the build. This affects the performance of
10 # the build since the symbols are large and dealing with them is slow. 11 # the build since the symbols are large and dealing with them is slow.
11 # 2 means regular build with symbols. 12 # 2 means regular build with symbols.
12 # 1 means minimal symbols, usually enough for backtraces only. 13 # 1 means minimal symbols, usually enough for backtraces only.
13 # 0 means no symbols. 14 # 0 means no symbols.
14 # -1 means auto-set according to debug/release and platform. 15 # -1 means auto-set according to debug/release and platform.
15 symbol_level = -1 16 symbol_level = -1
16 17
17 # Compile in such a way as to enable profiling of the generated code. For 18 # Compile in such a way as to enable profiling of the generated code. For
18 # example, don't omit the frame pointer and leave in symbols. 19 # example, don't omit the frame pointer and leave in symbols.
19 enable_profiling = false 20 enable_profiling = false
20 } 21 }
21 22
22 # If it wasn't manually set, set to an appropriate default. 23 # If it wasn't manually set, set to an appropriate default.
23 assert(symbol_level >= -1 && symbol_level <= 2, "Invalid symbol_level") 24 assert(symbol_level >= -1 && symbol_level <= 2, "Invalid symbol_level")
24 if (symbol_level == -1) { 25 if (symbol_level == -1) {
26 if (is_android && use_order_profiling) {
27 # With instrumentation enabled, debug info puts libchrome.so over 4gb, which
28 # causes the linker to produce an invalid ELF. http://crbug.com/574476
29 symbol_level = 0
30 }
31
25 # Linux is slowed by having symbols as part of the target binary, whereas 32 # Linux is slowed by having symbols as part of the target binary, whereas
26 # Mac and Windows have them separate, so in Release Linux, default them off, 33 # Mac and Windows have them separate, so in Release Linux, default them off,
27 # but keep them on for Official builds. 34 # but keep them on for Official builds.
28 if (!is_linux || (is_debug || is_official_build)) { 35 if (!is_linux || (is_debug || is_official_build)) {
29 symbol_level = 2 36 symbol_level = 2
30 } else if (using_sanitizer) { 37 } else if (using_sanitizer) {
31 # Sanitizers require symbols for filename suppressions to work. 38 # Sanitizers require symbols for filename suppressions to work.
32 symbol_level = 1 39 symbol_level = 1
33 } else { 40 } else {
34 symbol_level = 0 41 symbol_level = 0
35 } 42 }
36 } 43 }
OLDNEW
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698