Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Issue 1588673003: Disable debug information when use_order_profiling=true (Closed)

Created:
4 years, 11 months ago by agrieve
Modified:
4 years, 11 months ago
Reviewers:
pasko
CC:
chromium-reviews, pkotwicz
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable debug information when use_order_profiling=true We recently hit a limit when using use_order_profiling=true and symbol_level=2 where libchrome.so > 4gb and become corrupt. BUG=574476 Committed: https://crrev.com/95df83fbdb3d70584619ead0912708c773056c77 Cr-Commit-Position: refs/heads/master@{#369777}

Patch Set 1 #

Patch Set 2 : fix gyp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -9 lines) Patch
M build/common.gypi View 1 4 chunks +17 lines, -9 lines 0 comments Download
M build/config/compiler/compiler.gni View 2 chunks +7 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 15 (8 generated)
agrieve
On 2016/01/13 20:58:52, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:pasko@chromium.org \o/ Glad that ...
4 years, 11 months ago (2016-01-13 20:59:29 UTC) #3
pasko
On 2016/01/13 20:59:29, agrieve wrote: > On 2016/01/13 20:58:52, agrieve wrote: > > mailto:agrieve@chromium.org changed ...
4 years, 11 months ago (2016-01-14 09:51:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1588673003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1588673003/1
4 years, 11 months ago (2016-01-15 03:13:18 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/135949) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 11 months ago (2016-01-15 03:16:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1588673003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1588673003/20001
4 years, 11 months ago (2016-01-15 16:06:46 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-15 17:16:31 UTC) #13
commit-bot: I haz the power
4 years, 11 months ago (2016-01-15 17:18:10 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/95df83fbdb3d70584619ead0912708c773056c77
Cr-Commit-Position: refs/heads/master@{#369777}

Powered by Google App Engine
This is Rietveld 408576698