Allow Resize to be called w/ a preallocated pixmap

Allow Resize to be called w/ a preallocated pixmap

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1588653002

Committed: https://skia.googlesource.com/skia/+/97c40072b0ed5fdca3724ec79dd09d5467a981b5

[reed1, 2016-01-13 18:57:52]

Description was changed from

==========
Allow Resize to be called w/ a preallocated pixmap

BUG=skia:
==========

to

==========
Allow Resize to be called w/ a preallocated pixmap

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[reed1, 2016-01-13 18:58:56]

reed@google.com changed reviewers:
+ caryclark@google.com, robertphillips@google.com

[reed1, 2016-01-13 18:58:57]

This will allow the mipmap builder to call Resize directly, w/o needing to copy
from a bitmap.

[reed1, 2016-01-13 18:59:01]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-13 18:59:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1588653002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1588653002/1

[commit-bot: I haz the power, 2016-01-13 19:09:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-13 19:09:37]

Dry run: This issue passed the CQ dry run.

[reed1, 2016-01-13 19:37:07]

reed@google.com changed reviewers:
+ fmalita@chromium.org

[reed1, 2016-01-13 19:37:08]

ptal

[caryclark, 2016-01-13 20:22:53]

Does this warrant a new test?

https://codereview.chromium.org/1588653002/diff/1/src/core/SkBitmapScaler.h
File src/core/SkBitmapScaler.h (right):

https://codereview.chromium.org/1588653002/diff/1/src/core/SkBitmapScaler.h#n...
src/core/SkBitmapScaler.h:32: static bool Resize(const SkPixmap& dst, const
SkPixmap& src, ResizeMethod method);
At a casual glance, I would expect that this does not alter dst since it is
const.

[reed1, 2016-01-13 20:29:10]

On 2016/01/13 20:22:53, caryclark wrote:
> Does this warrant a new test?
> 
> https://codereview.chromium.org/1588653002/diff/1/src/core/SkBitmapScaler.h
> File src/core/SkBitmapScaler.h (right):
> 
>
https://codereview.chromium.org/1588653002/diff/1/src/core/SkBitmapScaler.h#n...
> src/core/SkBitmapScaler.h:32: static bool Resize(const SkPixmap& dst, const
> SkPixmap& src, ResizeMethod method);
> At a casual glance, I would expect that this does not alter dst since it is
> const.

That's tough: it does not alter dst the struct (and that's important). However,
dst can point to writable pixels. It seemed to me that marking dst as non-const
would be more confusing. I can add a comment (duh) that notes that we will write
into dst's pixels.

[caryclark, 2016-01-13 20:32:49]

lgtm

[robertphillips, 2016-01-13 20:41:38]

lgtm

https://codereview.chromium.org/1588653002/diff/1/src/core/SkBitmapScaler.h
File src/core/SkBitmapScaler.h (right):

https://codereview.chromium.org/1588653002/diff/1/src/core/SkBitmapScaler.h#n...
src/core/SkBitmapScaler.h:32: static bool Resize(const SkPixmap& dst, const
SkPixmap& src, ResizeMethod method);
On 2016/01/13 20:22:53, caryclark wrote:
> At a casual glance, I would expect that this does not alter dst since it is
> const.

I agree - it seems odd.

[reed1, 2016-01-13 21:21:34]

The CQ bit was checked by reed@google.com

[reed1, 2016-01-13 21:21:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com, caryclark@google.com
Link to the patchset: https://codereview.chromium.org/1588653002/#ps20001
(title: "update dox, clarifying dst's treatment")

[commit-bot: I haz the power, 2016-01-13 21:21:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1588653002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1588653002/20001

[commit-bot: I haz the power, 2016-01-13 21:36:33]

Description was changed from

==========
Allow Resize to be called w/ a preallocated pixmap

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Allow Resize to be called w/ a preallocated pixmap

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/97c40072b0ed5fdca3724ec79dd09d5467a981b5
==========

[commit-bot: I haz the power, 2016-01-13 21:36:34]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/97c40072b0ed5fdca3724ec79dd09d5467a981b5