Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 1588623002: ts_mon: remove dependency on apiclient. (Closed)

Created:
4 years, 11 months ago by Sergey Berezin
Modified:
4 years, 11 months ago
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

ts_mon: remove dependency on apiclient. apiclient is just an alias to googleapiclient, and the latter can be used directly. Also remove third_party from gae_ts_mon - move symlinks to the top level. This simplifies vendoring to luci-py. R=pgervais@chromium.org BUG=560481 Committed: https://chromium.googlesource.com/infra/infra/+/d64faecc426433933221f7595db46a23155086ac

Patch Set 1 #

Patch Set 2 : Remove gae_ts_mon/third_party #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -23 lines) Patch
M appengine_module/gae_ts_mon/__init__.py View 1 1 chunk +0 lines, -3 lines 0 comments Download
A appengine_module/gae_ts_mon/googleapiclient View 1 1 chunk +1 line, -0 lines 0 comments Download
A appengine_module/gae_ts_mon/httplib2 View 1 1 chunk +1 line, -0 lines 0 comments Download
A appengine_module/gae_ts_mon/oauth2client View 1 1 chunk +1 line, -0 lines 0 comments Download
A appengine_module/gae_ts_mon/six.py View 1 1 chunk +1 line, -0 lines 0 comments Download
D appengine_module/gae_ts_mon/third_party/__init__.py View 1 1 chunk +0 lines, -11 lines 0 comments Download
D appengine_module/gae_ts_mon/third_party/apiclient View 1 1 chunk +0 lines, -1 line 0 comments Download
D appengine_module/gae_ts_mon/third_party/googleapiclient View 1 1 chunk +0 lines, -1 line 0 comments Download
D appengine_module/gae_ts_mon/third_party/httplib2 View 1 1 chunk +0 lines, -1 line 0 comments Download
D appengine_module/gae_ts_mon/third_party/oauth2client View 1 1 chunk +0 lines, -1 line 0 comments Download
D appengine_module/gae_ts_mon/third_party/six.py View 1 1 chunk +0 lines, -1 line 0 comments Download
D appengine_module/gae_ts_mon/third_party/uritemplate View 1 1 chunk +0 lines, -1 line 0 comments Download
A appengine_module/gae_ts_mon/uritemplate View 1 1 chunk +1 line, -0 lines 0 comments Download
M infra_libs/ts_mon/common/monitors.py View 1 chunk +1 line, -1 line 0 comments Download
M infra_libs/ts_mon/common/test/monitors_test.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Sergey Berezin
PTAL - this is in preparation for luci-py vendoring (take 2)
4 years, 11 months ago (2016-01-13 18:43:47 UTC) #1
pgervais
On 2016/01/13 18:43:47, Sergey Berezin wrote: > PTAL - this is in preparation for luci-py ...
4 years, 11 months ago (2016-01-14 00:40:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1588623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1588623002/20001
4 years, 11 months ago (2016-01-14 01:15:59 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/infra/infra/+/d64faecc426433933221f7595db46a23155086ac
4 years, 11 months ago (2016-01-14 01:19:30 UTC) #7
Sergiy Byelozyorov (Google)
This broke chromium_try_flakes.
4 years, 11 months ago (2016-01-14 11:18:26 UTC) #9
Sergiy Byelozyorov
4 years, 11 months ago (2016-01-14 11:22:51 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1583243002/ by sergiyb@chromium.org.

The reason for reverting is: This broke chromium_try_flakes. I am not sure why,
but after this change I get an error on importing six from gae_ts_mon. Possibly
this is because there is another version of six in appengine/third_party..

Powered by Google App Engine
This is Rietveld 408576698