Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1588563002: [turbofan] Representation inference of shift should depends on the propagated type. (Closed)

Created:
4 years, 11 months ago by Jarin
Modified:
4 years, 11 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Representation inference of shift should depends on the propagated type. Committed: https://crrev.com/7ad13bf83bd655fb7a1f9b30b73aa2e71ac514a7 Cr-Commit-Position: refs/heads/master@{#33293}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -7 lines) Patch
M src/compiler/simplified-lowering.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/simplified-lowering.cc View 3 chunks +15 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1588563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1588563002/1
4 years, 11 months ago (2016-01-13 16:12:44 UTC) #2
Jarin
Could you take a look, please?
4 years, 11 months ago (2016-01-13 16:13:06 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-13 16:32:27 UTC) #6
Benedikt Meurer
lgtm
4 years, 11 months ago (2016-01-14 11:47:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1588563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1588563002/1
4 years, 11 months ago (2016-01-14 11:48:12 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-14 11:50:29 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 11:51:30 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/7ad13bf83bd655fb7a1f9b30b73aa2e71ac514a7
Cr-Commit-Position: refs/heads/master@{#33293}

Powered by Google App Engine
This is Rietveld 408576698