Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBlock.h

Issue 1588543004: Remove paintInvalidationRect from display item client invalidation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutBlock.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2007 David Smith (catfish.man@gmail.com) 4 * (C) 2007 David Smith (catfish.man@gmail.com)
5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All r ights reserved. 5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All r ights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 360 matching lines...) Expand 10 before | Expand all | Expand 10 after
371 void computeSelfHitTestRects(Vector<LayoutRect>&, const LayoutPoint& layerOf fset) const override; 371 void computeSelfHitTestRects(Vector<LayoutRect>&, const LayoutPoint& layerOf fset) const override;
372 372
373 void updateBlockChildDirtyBitsBeforeLayout(bool relayoutChildren, LayoutBox& ); 373 void updateBlockChildDirtyBitsBeforeLayout(bool relayoutChildren, LayoutBox& );
374 374
375 // TODO(jchaffraix): We should rename this function as inline-flex and inlin e-grid as also covered. 375 // TODO(jchaffraix): We should rename this function as inline-flex and inlin e-grid as also covered.
376 // Alternatively it should be removed as we clarify the meaning of isAtomicI nlineLevel to imply 376 // Alternatively it should be removed as we clarify the meaning of isAtomicI nlineLevel to imply
377 // isInline. 377 // isInline.
378 bool isInlineBlockOrInlineTable() const final { return isInline() && isAtomi cInlineLevel(); } 378 bool isInlineBlockOrInlineTable() const final { return isInline() && isAtomi cInlineLevel(); }
379 379
380 void invalidatePaintOfSubtreesIfNeeded(PaintInvalidationState& childPaintInv alidationState) override; 380 void invalidatePaintOfSubtreesIfNeeded(PaintInvalidationState& childPaintInv alidationState) override;
381 void invalidateDisplayItemClients(const LayoutBoxModelObject& paintInvalidat ionContainer, PaintInvalidationReason, const LayoutRect* paintInvalidationRect) const override; 381 void invalidateDisplayItemClients(const LayoutBoxModelObject& paintInvalidat ionContainer, PaintInvalidationReason) const override;
382 382
383 private: 383 private:
384 LayoutObjectChildList* virtualChildren() final { return children(); } 384 LayoutObjectChildList* virtualChildren() final { return children(); }
385 const LayoutObjectChildList* virtualChildren() const final { return children (); } 385 const LayoutObjectChildList* virtualChildren() const final { return children (); }
386 386
387 bool isLayoutBlock() const final { return true; } 387 bool isLayoutBlock() const final { return true; }
388 388
389 void makeChildrenNonInline(LayoutObject* insertionPoint = nullptr); 389 void makeChildrenNonInline(LayoutObject* insertionPoint = nullptr);
390 390
391 virtual void removeLeftoverAnonymousBlock(LayoutBlock* child); 391 virtual void removeLeftoverAnonymousBlock(LayoutBlock* child);
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after
505 // FIXME: This is temporary as we move code that accesses block flow 505 // FIXME: This is temporary as we move code that accesses block flow
506 // member variables out of LayoutBlock and into LayoutBlockFlow. 506 // member variables out of LayoutBlock and into LayoutBlockFlow.
507 friend class LayoutBlockFlow; 507 friend class LayoutBlockFlow;
508 }; 508 };
509 509
510 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutBlock, isLayoutBlock()); 510 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutBlock, isLayoutBlock());
511 511
512 } // namespace blink 512 } // namespace blink
513 513
514 #endif // LayoutBlock_h 514 #endif // LayoutBlock_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutBlock.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698