Never connect a port to the same frame

Never connect a port to the same frame

Connecting to the same frame does not make sense because onMessage
should not be triggered for the same frame.

BUG=479425, 575234
Committed: https://crrev.com/0a6b622545af1c2c8fe3ef1863020e1d9c8ba6e6
Cr-Commit-Position: refs/heads/master@{#369379}

[robwu, 2016-01-13 13:55:55]

rob@robwu.nl changed reviewers:
+ rdevlin.cronin@chromium.org

[Devlin, 2016-01-13 17:37:22]

lgtm.

I have some slight reservations that we shouldn't necessarily disallow listening
to a message from the same frame, but I suppose any consistency is better than
the current state (and I can't yet think of a good use case for it).

https://codereview.chromium.org/1588533002/diff/1/chrome/browser/extensions/a...
File chrome/browser/extensions/api/messaging/message_service.cc (right):

https://codereview.chromium.org/1588533002/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/messaging/message_service.cc:579: // Remove
duplicate frames.
Nit: since all this method does is check for duplicates, let's rename it to be
more clear what the intent is.

[robwu, 2016-01-13 19:56:20]

https://codereview.chromium.org/1588533002/diff/1/chrome/browser/extensions/a...
File chrome/browser/extensions/api/messaging/message_service.cc (right):

https://codereview.chromium.org/1588533002/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/messaging/message_service.cc:579: // Remove
duplicate frames.
On 2016/01/13 17:37:22, Devlin wrote:
> Nit: since all this method does is check for duplicates, let's rename it to be
> more clear what the intent is.

Done (renamed to RemoveCommonFrames).

[robwu, 2016-01-13 19:56:34]

The CQ bit was checked by rob@robwu.nl

[robwu, 2016-01-13 19:56:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/1588533002/#ps20001
(title: "s/WillConnectToPort/RemoveCommonFrames/")

[commit-bot: I haz the power, 2016-01-13 19:56:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1588533002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1588533002/20001

[commit-bot: I haz the power, 2016-01-13 20:08:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-13 20:08:25]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[robwu, 2016-01-13 20:12:45]

Patchset #2 (id:20001) has been deleted

[robwu, 2016-01-13 20:13:13]

The CQ bit was checked by rob@robwu.nl

[robwu, 2016-01-13 20:13:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/1588533002/#ps40001
(title: "s/WillConnectToPort/RemoveCommonFrames/")

[commit-bot: I haz the power, 2016-01-13 20:14:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1588533002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1588533002/40001

[commit-bot: I haz the power, 2016-01-13 20:23:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-13 20:23:43]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[robwu, 2016-01-14 00:20:03]

The CQ bit was checked by rob@robwu.nl

[robwu, 2016-01-14 00:20:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/1588533002/#ps60001
(title: "Also rename invocation of WillConnectToPort")

[commit-bot: I haz the power, 2016-01-14 00:22:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1588533002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1588533002/60001

[commit-bot: I haz the power, 2016-01-14 02:12:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-14 02:12:02]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[robwu, 2016-01-14 08:44:28]

The CQ bit was checked by rob@robwu.nl

[commit-bot: I haz the power, 2016-01-14 08:44:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1588533002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1588533002/60001

[commit-bot: I haz the power, 2016-01-14 09:28:22]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-01-14 09:29:12]

Description was changed from

==========
Never connect a port to the same frame

Connecting to the same frame does not make sense because onMessage
should not be triggered for the same frame.

BUG=479425,575234
==========

to

==========
Never connect a port to the same frame

Connecting to the same frame does not make sense because onMessage
should not be triggered for the same frame.

BUG=479425,575234

Committed: https://crrev.com/0a6b622545af1c2c8fe3ef1863020e1d9c8ba6e6
Cr-Commit-Position: refs/heads/master@{#369379}
==========

[commit-bot: I haz the power, 2016-01-14 09:29:12]

Patchset 3 (id:??) landed as
https://crrev.com/0a6b622545af1c2c8fe3ef1863020e1d9c8ba6e6
Cr-Commit-Position: refs/heads/master@{#369379}