Use a local variable as a character cursor in genericParseNumber

Use a local variable as a character cursor in genericParseNumber

Don't move the 'out' variable |cursor| until a valid number has been
parsed (disregarding the leading whitespace).
This will allow generating better error messages in some cases (the cursor
will not "stop" randomly within the number upon encountering overflows
etc.). It also enables "re-parsing" although currently no call-sites
require that. Code size virtually unaffected (-7 for LChar, +2 for UChar.)

BUG=231612
Committed: https://crrev.com/f16520b843b6214481015adf4a8372d2e47f3dea
Cr-Commit-Position: refs/heads/master@{#369391}

[fs, 2016-01-13 23:37:23]

fs@opera.com changed reviewers:
+ pdr@chromium.org

[fs, 2016-01-13 23:37:23]

CQ not smiling on me today... This is on top of
https://codereview.chromium.org/1582813003/, but I'm sure you can filter that
out...

Good night.

[pdr., 2016-01-13 23:44:10]

On 2016/01/13 at 23:37:23, fs wrote:
> CQ not smiling on me today... This is on top of
https://codereview.chromium.org/1582813003/, but I'm sure you can filter that
out...
> 
> Good night.

LGTM too.

It's not just you, the CQ doesn't like any patches at the moment :/

[pdr., 2016-01-13 23:47:39]

On 2016/01/13 at 23:44:10, pdr wrote:
> On 2016/01/13 at 23:37:23, fs wrote:
> > CQ not smiling on me today... This is on top of
https://codereview.chromium.org/1582813003/, but I'm sure you can filter that
out...
> > 
> > Good night.
> 
> LGTM too.
> 
> It's not just you, the CQ doesn't like any patches at the moment :/

https://code.google.com/p/chromium/issues/detail?id=577359 to follow along with
the fun.

[fs, 2016-01-14 09:27:51]

On 2016/01/13 at 23:47:39, pdr wrote:
> On 2016/01/13 at 23:44:10, pdr wrote:
> > On 2016/01/13 at 23:37:23, fs wrote:
> > > CQ not smiling on me today... This is on top of
https://codereview.chromium.org/1582813003/, but I'm sure you can filter that
out...
> > > 
> > > Good night.
> > 
> > LGTM too.
> > 
> > It's not just you, the CQ doesn't like any patches at the moment :/
> 
> https://code.google.com/p/chromium/issues/detail?id=577359 to follow along
with the fun.

Lots of 403 fun!

[fs, 2016-01-14 11:21:23]

The CQ bit was checked by fs@opera.com

[fs, 2016-01-14 11:21:23]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/1588453006/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2016-01-14 11:21:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1588453006/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1588453006/40001

[commit-bot: I haz the power, 2016-01-14 11:25:36]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-14 11:27:12]

Description was changed from

==========
Use a local variable as a character cursor in genericParseNumber

Don't move the 'out' variable |cursor| until a valid number has been
parsed (disregarding the leading whitespace).
This will allow generating better error messages in some cases (the cursor
will not "stop" randomly within the number upon encountering overflows
etc.). It also enables "re-parsing" although currently no call-sites
require that. Code size virtually unaffected (-7 for LChar, +2 for UChar.)

BUG=231612
==========

to

==========
Use a local variable as a character cursor in genericParseNumber

Don't move the 'out' variable |cursor| until a valid number has been
parsed (disregarding the leading whitespace).
This will allow generating better error messages in some cases (the cursor
will not "stop" randomly within the number upon encountering overflows
etc.). It also enables "re-parsing" although currently no call-sites
require that. Code size virtually unaffected (-7 for LChar, +2 for UChar.)

BUG=231612

Committed: https://crrev.com/f16520b843b6214481015adf4a8372d2e47f3dea
Cr-Commit-Position: refs/heads/master@{#369391}
==========

[commit-bot: I haz the power, 2016-01-14 11:27:13]

Patchset 3 (id:??) landed as
https://crrev.com/f16520b843b6214481015adf4a8372d2e47f3dea
Cr-Commit-Position: refs/heads/master@{#369391}