Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/safe_browsing/two_phase_uploader.cc

Issue 15881012: Implement safebrowsing download feedback service, enabled for dev & canary only. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/safe_browsing/download_feedback_service.cc ('K') | « chrome/browser/safe_browsing/two_phase_uploader.h ('k') | chrome/browser/ui/views/download/download_item_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/two_phase_uploader.cc
diff --git a/chrome/browser/safe_browsing/two_phase_uploader.cc b/chrome/browser/safe_browsing/two_phase_uploader.cc
index 93720ead770e3b3d5f4ae60cd183e1d05753b36e..aa80d263df1230480f86f2e5cc58aa2d709b8f6d 100644
--- a/chrome/browser/safe_browsing/two_phase_uploader.cc
+++ b/chrome/browser/safe_browsing/two_phase_uploader.cc
@@ -153,7 +153,7 @@ void TwoPhaseUploaderImpl::OnURLFetchUploadProgress(
DCHECK(CalledOnValidThread());
DVLOG(3) << __FUNCTION__ << " " << source->GetURL().spec()
<< " " << current << "/" << total;
- if (state_ == UPLOAD_FILE)
+ if (state_ == UPLOAD_FILE && !progress_callback_.is_null())
progress_callback_.Run(current, total);
}
« chrome/browser/safe_browsing/download_feedback_service.cc ('K') | « chrome/browser/safe_browsing/two_phase_uploader.h ('k') | chrome/browser/ui/views/download/download_item_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698