Implement safebrowsing download feedback service, enabled for dev & canary only.

tools/metrics/histograms/histograms.xml

 <!--
 Copyright 2013 The Chromium Authors. All rights reserved.
 Use of this source code is governed by a BSD-style license that can be
 found in the LICENSE file.
 -->
 
 <!--
 This file is used to generate a comprehensive list of Chrome histograms along
 with a detailed description for each histogram.
 
@@ skipping 923 matching lines @@
 </histogram>
 
 <histogram name="clickjacking.launch_url">
   <summary>TBD</summary>
 </histogram>
 
 <histogram name="clickjacking.open_download">
   <summary>TBD</summary>
 </histogram>
 
+<histogram name="clickjacking.report_and_discard_download" units="ms">
+  <summary>
+    Time between &quot;Report and Discard&quot; button being shown and it being
+    clicked.
+  </summary>
+</histogram>
+
 <histogram name="clickjacking.save_download">
   <summary>TBD</summary>
 </histogram>
 
 <histogram name="Clipboard.IncognitoUseCase" enum="ClipboardAction">
   <obsolete>
     Deprecated as of 4/2013, experiment confirmed correctness of our patch.
   </obsolete>
   <summary>
     Counts how often the user writes or reads from the clipboard and whether the
@@ skipping 9620 matching lines @@
     kMaxFeatureSize is too small.
   </summary>
 </histogram>
 
 <histogram name="SBClientPhishing.URLFeatureTime" units="milliseconds">
   <summary>
     The time taken to extract URL features for the phishing classifier.
   </summary>
 </histogram>
 
+<histogram name="SBDownloadFeedback.Activations" enum="DownloadItem.DangerType">
+  <summary>
+    Count of times download feedback has been started, broken down by danger
+    type.
+  </summary>
+</histogram>
+
+<histogram name="SBDownloadFeedback.ActiveFeedbacks">
+  <summary>
+    When a new download feedback request is added, records the number of
+    download requests currently active and/or pending.
+  </summary>
+</histogram>
+
+<histogram name="SBDownloadFeedback.Shown" enum="DownloadItem.DangerType">
+  <summary>
+    Count of times download feedback button has been shown, broken down by
+    danger type.
+  </summary>
+</histogram>
+
+<histogram name="SBDownloadFeedback.SizeEligibleKB" units="KB">
+  <summary>
+    Size of downloads that were of the correct danger type, regardless if they
+    meet the max file size check or if they are actually uploaded or not.
+  </summary>
+</histogram>
+
+<histogram name="SBDownloadFeedback.SizeFailure" units="bytes">

[Ilya Sherman, 2013/06/14 23:26:28]

Why are this histogram and the one below in bytes, whereas the one above is in
KB?

+  <summary>
+    Size of downloads that failed to be uploaded to the feedback service.
+  </summary>
+</histogram>
+
+<histogram name="SBDownloadFeedback.SizeSuccess" units="bytes">
+  <summary>
+    Size of downloads that were successfully uploaded to the feedback service.
+  </summary>
+</histogram>
+
+<histogram name="SBDownloadFeedback.UploadResult"
+    enum="SBDownloadFeedbackUploadResult">
+  <summary>
+    Final result of attempt to upload binary to download feedback service.
+  </summary>
+</histogram>
+
 <histogram name="Search.DefaultSearchProvider" enum="OmniboxSearchEngine">
   <summary>
     The id of the default search engine that is loaded after Chrome startup. See
     src/chrome/browser/search_engines/prepopulate_engines.json for more info.
   </summary>
 </histogram>
 
 <histogram name="SimpleCache.CheckCRCResult" enum="CheckCRCResult">
   <summary>
     Whether or not the CRC was checked at the moment when the last reference to
@@ skipping 6622 matching lines @@
 
 <enum name="SBClientPhishingScorerCreationStatus" type="int">
   <int value="0" label="SUCCESS"/>
   <int value="1" label="MODEL_OPEN_FAIL"/>
   <int value="2" label="MODEL_FILE_EMPTY"/>
   <int value="3" label="MODEL_FILE_TOO_LARGE"/>
   <int value="4" label="MODEL_PARSE_ERROR"/>
   <int value="5" label="MODEL_MISSING_FIELDS"/>
 </enum>
 
+<enum name="SBDownloadFeedbackUploadResult" type="int">
+  <int value="0" label="SUCCESS"/>
+  <int value="1" label="UPLOAD_SUCCESS"/>
+  <int value="2" label="UPLOAD_CANCELLED"/>
+  <int value="3" label="UPLOAD_METADATA_NET_ERROR"/>
+  <int value="4" label="UPLOAD_METADATA_RESPONSE_ERROR"/>
+  <int value="5" label="UPLOAD_FILE_NET_ERROR"/>
+  <int value="6" label="UPLOAD_FILE_RESPONSE_ERROR"/>
+  <int value="7" label="UPLOAD_COMPLETE_RESPONSE_ERROR"/>
+</enum>
+
 <enum name="ShillTerminationActionResult" type="int">
   <summary>
     The termination action result types come from TerminationActionResult in
     shill/metrics.h
   </summary>
   <int value="0" label="Success"/>
   <int value="1" label="Failure"/>
 </enum>
 
 <enum name="SideloadUIEvents" type="int">
@@ skipping 2277 matching lines @@
   <group name="Disabled" label="Neither extra webstore link is visible"/>
   <group name="FooterLink" label="Link in bottom right of footer"/>
   <group name="PlusIcon" label="Plus icon in apps page"/>
   <affected-histogram name="Extensions.AppLaunch"/>
   <affected-histogram name="NewTabPage.DefaultPageType"/>
 </fieldtrial>
 
 </fieldtrials>
 
 </histogram-configuration>