Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Unified Diff: chrome/browser/translate/translate_manager.cc

Issue 15881006: Added 'error logs' tab to chrome://translte-internals. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/translate/translate_manager.cc
diff --git a/chrome/browser/translate/translate_manager.cc b/chrome/browser/translate/translate_manager.cc
index 1046922ec62af6e459ac1b4fa785e94b5041e1be..fdc4c62565b812e5c5318437d75fd991799e97b3 100644
--- a/chrome/browser/translate/translate_manager.cc
+++ b/chrome/browser/translate/translate_manager.cc
@@ -23,6 +23,7 @@
#include "chrome/browser/tab_contents/language_state.h"
#include "chrome/browser/tab_contents/tab_util.h"
#include "chrome/browser/translate/page_translated_details.h"
+#include "chrome/browser/translate/translate_error_details.h"
#include "chrome/browser/translate/translate_infobar_delegate.h"
#include "chrome/browser/translate/translate_manager_metrics.h"
#include "chrome/browser/translate/translate_prefs.h"
@@ -495,6 +496,12 @@ void TranslateManager::OnURLFetchComplete(const net::URLFetcher* source) {
ShortcutConfig(),
request.source_lang,
request.target_lang);
+
+ TranslateErrorDetails error_details;
+ error_details.time = base::Time::Now();
+ error_details.url = entry->GetURL();
+ error_details.error = TranslateErrors::NETWORK;
+ NotifyTranslateError(error_details);
} else {
// Translate the page.
DoTranslatePage(web_contents, translate_script_,
@@ -528,6 +535,10 @@ void TranslateManager::NotifyLanguageDetection(
FOR_EACH_OBSERVER(Observer, observer_list_, OnLanguageDetection(details));
}
+void TranslateManager::NotifyTranslateError(
+ const TranslateErrorDetails& details) {
+ FOR_EACH_OBSERVER(Observer, observer_list_, OnTranslateError(details));
+}
TranslateManager::TranslateManager()
: weak_method_factory_(this),
@@ -807,10 +818,18 @@ void TranslateManager::PageTranslated(WebContents* web_contents,
TranslateInfoBarDelegate::Create(
InfoBarService::FromWebContents(web_contents), true,
(details->error_type == TranslateErrors::NONE) ?
- TranslateInfoBarDelegate::AFTER_TRANSLATE :
- TranslateInfoBarDelegate::TRANSLATION_ERROR,
+ TranslateInfoBarDelegate::AFTER_TRANSLATE :
+ TranslateInfoBarDelegate::TRANSLATION_ERROR,
details->error_type, prefs, ShortcutConfig(), details->source_language,
details->target_language);
+
+ if (details->error_type != TranslateErrors::NONE) {
+ TranslateErrorDetails error_details;
+ error_details.time = base::Time::Now();
+ error_details.url = web_contents->GetActiveURL();
+ error_details.error = details->error_type;
+ NotifyTranslateError(error_details);
+ }
}
bool TranslateManager::IsAcceptLanguage(WebContents* web_contents,

Powered by Google App Engine
This is Rietveld 408576698