Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15881006: Added 'error logs' tab to chrome://translte-internals. (Closed)

Created:
7 years, 7 months ago by hajimehoshi
Modified:
7 years, 6 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Added 'error logs' tab to chrome://translte-internals. Added 'error logs' tab. For now, simply TranslateErrors::Type is logged. More error details will be logged when we can get those from Translate API. BUG=175967 TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202804

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed unnecessary files #

Total comments: 2

Patch Set 3 : Fixed a comment #

Patch Set 4 : (Rebasing) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -2 lines) Patch
A chrome/browser/resources/translate_internals/error_logs.html View 1 chunk +18 lines, -0 lines 0 comments Download
M chrome/browser/resources/translate_internals/translate_internals.css View 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/browser/resources/translate_internals/translate_internals.html View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/resources/translate_internals/translate_internals.js View 1 2 3 4 chunks +54 lines, -0 lines 0 comments Download
A chrome/browser/translate/translate_error_details.h View 1 1 chunk +23 lines, -0 lines 0 comments Download
M chrome/browser/translate/translate_manager.h View 1 2 3 3 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/translate/translate_manager.cc View 1 2 3 4 chunks +21 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/translate_internals/translate_internals_handler.h View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
hajimehoshi
toyoshim@, can you take a look? Thank you in advance.
7 years, 7 months ago (2013-05-27 09:28:49 UTC) #1
Takashi Toyoshima
lgtm with nits. https://codereview.chromium.org/15881006/diff/1/chrome/browser/translate/translate_error_details.h File chrome/browser/translate/translate_error_details.h (right): https://codereview.chromium.org/15881006/diff/1/chrome/browser/translate/translate_error_details.h#newcode13 chrome/browser/translate/translate_error_details.h:13: TranslateErrorDetails(); remove these constructor/destructor.
7 years, 7 months ago (2013-05-27 10:15:34 UTC) #2
hajimehoshi
Thank you! https://codereview.chromium.org/15881006/diff/1/chrome/browser/translate/translate_error_details.h File chrome/browser/translate/translate_error_details.h (right): https://codereview.chromium.org/15881006/diff/1/chrome/browser/translate/translate_error_details.h#newcode13 chrome/browser/translate/translate_error_details.h:13: TranslateErrorDetails(); On 2013/05/27 10:15:34, Takashi Toyoshima (chromium) ...
7 years, 6 months ago (2013-05-28 01:31:24 UTC) #3
hajimehoshi
+sky, can you take a look at chrome/chrome_browser.gypi? +estade, can you take a look at ...
7 years, 6 months ago (2013-05-28 01:33:36 UTC) #4
hajimehoshi
+sky, Sorry, but chrome_browser.gypi can be reviewed by anyone. On 2013/05/28 01:33:36, hajimehoshi wrote: > ...
7 years, 6 months ago (2013-05-28 09:50:12 UTC) #5
Evan Stade
https://codereview.chromium.org/15881006/diff/5001/chrome/browser/resources/translate_internals/translate_internals.js File chrome/browser/resources/translate_internals/translate_internals.js (right): https://codereview.chromium.org/15881006/diff/5001/chrome/browser/resources/translate_internals/translate_internals.js#newcode64 chrome/browser/resources/translate_internals/translate_internals.js:64: * @param {string} The formatted string. why are there ...
7 years, 6 months ago (2013-05-28 16:59:36 UTC) #6
hajimehoshi
Thank you! https://codereview.chromium.org/15881006/diff/5001/chrome/browser/resources/translate_internals/translate_internals.js File chrome/browser/resources/translate_internals/translate_internals.js (right): https://codereview.chromium.org/15881006/diff/5001/chrome/browser/resources/translate_internals/translate_internals.js#newcode64 chrome/browser/resources/translate_internals/translate_internals.js:64: * @param {string} The formatted string. I ...
7 years, 6 months ago (2013-05-29 02:01:41 UTC) #7
Evan Stade
lgtm
7 years, 6 months ago (2013-05-29 02:14:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hajimehoshi@chromium.org/15881006/17001
7 years, 6 months ago (2013-05-29 02:35:16 UTC) #9
commit-bot: I haz the power
7 years, 6 months ago (2013-05-29 07:54:10 UTC) #10
Message was sent while issue was closed. 
Change committed as 202804

Powered by Google App Engine
This is Rietveld 408576698