Issue 15881003: Remove offset() and is_in_object() from hydrogen and lithium LoadNamedField and StoreNamedField and…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15881003: Remove offset() and is_in_object() from hydrogen and lithium LoadNamedField and StoreNamedField and… (Closed)

Created:
7 years, 7 months ago by titzer

Modified:
7 years, 7 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Remove offset() and is_in_object() from hydrogen and lithium LoadNamedField and StoreNamedField and use the appropriate methods on HObjectAccess instead BUG= Committed: https://code.google.com/p/v8/source/detail?r=14806

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -47 lines)			Patch
M	src/arm/lithium-arm.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/arm/lithium-arm.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	5 chunks	+8 lines, -5 lines	0 comments	Download
M	src/hydrogen-instructions.h	View	4 chunks	+5 lines, -6 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	6 chunks	+8 lines, -7 lines	0 comments	Download
M	src/ia32/lithium-ia32.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/ia32/lithium-ia32.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	src/mips/lithium-codegen-mips.cc	View	5 chunks	+7 lines, -5 lines	0 comments	Download
M	src/mips/lithium-mips.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/mips/lithium-mips.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	6 chunks	+8 lines, -6 lines	0 comments	Download
M	src/x64/lithium-x64.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/x64/lithium-x64.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

titzer

7 years, 7 months ago (2013-05-24 12:40:21 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r14806 (presubmit successful).

Expand Messages | Collapse Messages