Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1588093005: Build lib/_internal/analysis_summary during SDK build. (Closed)

Created:
4 years, 11 months ago by scheglov
Modified:
4 years, 10 months ago
Reviewers:
Paul Berry, Bill Hesse
CC:
reviews_dartlang.org, ricow1
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Build lib/_internal/analysis_summary during SDK build. We cannot commit this CL right now, because we will attempt to use these summaries by default, and they are incomplete yet. But I wanted to see how to add something to the build process, and we might do changes to make using SDK summaries optional initiallyand then commit this CL. R=paulberry@google.com, whesse@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/427f760c9116ce9657718f8f89dd8f786c27739a

Patch Set 1 #

Patch Set 2 : Update to use the new build_sdk_summaries.dart script. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -2 lines) Patch
M create_sdk.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tools/create_sdk.py View 1 3 chunks +11 lines, -2 lines 0 comments Download
M utils/dartanalyzer/dartanalyzer.gyp View 1 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
scheglov
4 years, 11 months ago (2016-01-15 16:37:56 UTC) #1
Paul Berry
lgtm, but I don't really understand the build system very well, so my review probably ...
4 years, 11 months ago (2016-01-15 16:44:04 UTC) #2
Bill Hesse
lgtm
4 years, 10 months ago (2016-02-08 10:27:10 UTC) #3
scheglov
PTAL We generate two summary files: spec.sum and strong.sum now. If this looks good, I ...
4 years, 10 months ago (2016-02-19 22:39:48 UTC) #4
Paul Berry
lgtm
4 years, 10 months ago (2016-02-19 22:47:24 UTC) #5
Bill Hesse
LGTM. Please find the impact on the SDK size, and report that, and the problem ...
4 years, 10 months ago (2016-02-19 23:20:27 UTC) #6
scheglov
4 years, 10 months ago (2016-02-20 03:06:12 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
427f760c9116ce9657718f8f89dd8f786c27739a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698