Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Unified Diff: pkg/analysis_server/lib/src/status/get_handler.dart

Issue 1588083003: Add list length information to the status pages (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/status/get_handler.dart
diff --git a/pkg/analysis_server/lib/src/status/get_handler.dart b/pkg/analysis_server/lib/src/status/get_handler.dart
index 72600138074b052053ce079b98026caab8214c32..37b2e9f3dee18a3e54035096e1acd1151ffed461 100644
--- a/pkg/analysis_server/lib/src/status/get_handler.dart
+++ b/pkg/analysis_server/lib/src/status/get_handler.dart
@@ -65,10 +65,10 @@ class ElementCounter extends RecursiveElementVisitor {
int totalDocSpan = 0;
void visit(Element element) {
- SourceRange docRange = element.docRange;
- if (docRange != null) {
+ String comment = element.documentationComment;
+ if (comment != null) {
++elementsWithDocs;
- totalDocSpan += docRange.length;
+ totalDocSpan += comment.length;
}
Type type = element.runtimeType;
@@ -1293,9 +1293,16 @@ class GetHandler {
buffer.write('<p><b>Error Processor count</b>: $processorCount</p>');
});
- _writeFiles(buffer, 'Priority Files', priorityNames);
- _writeFiles(buffer, 'Explicitly Analyzed Files', explicitNames);
- _writeFiles(buffer, 'Implicitly Analyzed Files', implicitNames);
+ _writeFiles(
+ buffer, 'Priority Files (${priorityNames.length})', priorityNames);
+ _writeFiles(
+ buffer,
+ 'Explicitly Analyzed Files (${explicitNames.length})',
+ explicitNames);
+ _writeFiles(
+ buffer,
+ 'Implicitly Analyzed Files (${implicitNames.length})',
+ implicitNames);
buffer.write('<h3>Exceptions</h3>');
if (exceptions.isEmpty) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698