Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1588053003: PPC: [Interpreter] Fix PushArgsAndConstruct (Closed)

Created:
4 years, 11 months ago by MTBrandyberry
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [Interpreter] Fix PushArgsAndConstruct Port 48a3227b7dd2f285aa599eb1cdf5f8bc94acdec7 Original commit message: When reserving a stack slot for the receiver, push an Immediate(0) rather than a register that contains an untagged integer. All other platforms push zero already. R=jkummerow@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/4faa262e9c471624abcd3403dc0c58376039e0ea Cr-Commit-Position: refs/heads/master@{#33314}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/ppc/builtins-ppc.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
MTBrandyberry
4 years, 11 months ago (2016-01-14 17:51:27 UTC) #1
michael_dawson
On 2016/01/14 17:51:27, mtbrandyberry wrote: lgtm
4 years, 11 months ago (2016-01-14 18:49:27 UTC) #3
JoranSiu
lgtm
4 years, 11 months ago (2016-01-14 18:50:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1588053003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1588053003/1
4 years, 11 months ago (2016-01-14 19:48:16 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-14 20:08:34 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 20:09:10 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4faa262e9c471624abcd3403dc0c58376039e0ea
Cr-Commit-Position: refs/heads/master@{#33314}

Powered by Google App Engine
This is Rietveld 408576698