Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 1588053002: Generalize 'fast accessor' tests to work with --always-opt. (Closed)

Created:
4 years, 11 months ago by vogelheim
Modified:
4 years, 11 months ago
Reviewers:
epertoso
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Generalize 'fast accessor' tests to work with --always-opt. BUG=508898 LOG=N Committed: https://crrev.com/8c04c33f28f8f18f68589344b3eddd8a45c54e31 Cr-Commit-Position: refs/heads/master@{#33297}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -30 lines) Patch
M test/cctest/test-api-accessors.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/test-api-fast-accessor-builder.cc View 12 chunks +42 lines, -28 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
vogelheim
.
4 years, 11 months ago (2016-01-14 14:01:34 UTC) #3
epertoso
lgtm
4 years, 11 months ago (2016-01-14 14:08:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1588053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1588053002/1
4 years, 11 months ago (2016-01-14 14:23:07 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-14 14:24:19 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 14:25:11 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8c04c33f28f8f18f68589344b3eddd8a45c54e31
Cr-Commit-Position: refs/heads/master@{#33297}

Powered by Google App Engine
This is Rietveld 408576698