Issue 158803002: Remove duplicate third-party test cases.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 158803002: Remove duplicate third-party test cases. (Closed)

Created:
6 years, 10 months ago by Michael Starzinger

Modified:
6 years, 10 months ago

Reviewers:
Michael Achenbach

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Remove duplicate third-party test cases. Some of the third-party test cases in the mjsunit test suite were originally taken from WebKit and are now fully covered by the equally named test suite. Mapping of test cases: - array-isarray.js -> test/webkit/Array-isArray.js - array-splice-webkit.js -> test/webkit/array-splice.js R=machenbach@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=19220

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -110 lines)			Patch
	D	test/mjsunit/third_party/array-isarray.js	View		1 chunk	+0 lines, -48 lines	0 comments	Download
	D	test/mjsunit/third_party/array-splice-webkit.js	View		1 chunk	+0 lines, -62 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Michael Achenbach

The CQ bit was checked by machenbach@chromium.org

6 years, 10 months ago (2014-02-10 11:26:17 UTC) #2

Michael Achenbach

The CQ bit was unchecked by machenbach@chromium.org

6 years, 10 months ago (2014-02-10 11:26:18 UTC) #3

Michael Starzinger

There are two test cases left. One is a PCRE reg-exp test and the other ...

6 years, 10 months ago (2014-02-10 11:29:09 UTC) #5

Michael Starzinger

6 years, 10 months ago (2014-02-10 11:30:06 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 manually as r19220 (presubmit successful).

Expand Messages | Collapse Messages