Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 1588013002: Robustify NewNumberFromSize against int-overflow on cast (Closed)

Created:
4 years, 11 months ago by Jakob Kummerow
Modified:
4 years, 11 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Robustify NewNumberFromSize against int-overflow on cast As luck would have it, there doesn't seem to be a way to trigger observable misbehavior currently (only with special flags). BUG=chromium:380671 LOG=n R=mvstanton@chromium.org Committed: https://crrev.com/b40a22dc87002419cb0fcab9acb2f018e311c5c8 Cr-Commit-Position: refs/heads/master@{#33305}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M src/factory.h View 1 chunk +3 lines, -1 line 0 comments Download
A + test/mjsunit/regress/regress-crbug-380671.js View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Jakob Kummerow
4 years, 11 months ago (2016-01-14 11:47:30 UTC) #1
mvstanton
lgtm
4 years, 11 months ago (2016-01-14 11:50:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1588013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1588013002/1
4 years, 11 months ago (2016-01-14 11:50:22 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/12378)
4 years, 11 months ago (2016-01-14 12:15:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1588013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1588013002/1
4 years, 11 months ago (2016-01-14 17:04:39 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-14 17:23:25 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 17:24:11 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b40a22dc87002419cb0fcab9acb2f018e311c5c8
Cr-Commit-Position: refs/heads/master@{#33305}

Powered by Google App Engine
This is Rietveld 408576698