Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1588003005: Revert of Service Worker: Add FetchEvent.clientId (Closed)

Created:
4 years, 11 months ago by huangs
Modified:
4 years, 11 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, blink-worker-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, falken, horo+watch_chromium.org, jam, jsbell+serviceworker_chromium.org, kinuko+watch, kinuko+serviceworker, michaeln, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nhiroki, serviceworker-reviews, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Service Worker: Add FetchEvent.clientId (patchset #8 id:170001 of https://codereview.chromium.org/1435633002/ ) Reason for revert: This CL is suspected to break Webkit Linux ASAN tests: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN/builds/8085/steps/webkit_tests/logs/stdio ==4==WARNING: MemorySanitizer: use-of-uninitialized-value ... #7 0xe5d7fd5 in Write content/common/service_worker/service_worker_messages.h:55:0 Please check initializaiton paths, and run on more ASAN bots before relanding. Original issue's description: > Service Worker: Add FetchEvent.clientId > > As per the latest spec update, this CL implements FetchEvent.clientId attribute. > > Spec discussion: https://github.com/slightlyoff/ServiceWorker/issues/723#issuecomment-151326898 > Spec: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#fetch-event-clientid > > Intent to implement and ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/XlBHOIOCjUk > > The layout tests for this CL are mostly taken from Mozilla's work instead of making new ones to ensure compatibility: https://bugzilla.mozilla.org/show_bug.cgi?id=1222464 > > BUG=552309 > > Committed: https://crrev.com/f1b2374078adf2068473bd9f81fd7615cf35d34d > Cr-Commit-Position: refs/heads/master@{#369649} TBR=dcheng@chromium.org,falken@chromium.org,jinho.bang@samsung.com,kinuko@chromium.org,michaeln@chromium.org,mkwst@chromium.org,nhiroki@chromium.org,palmer@chromium.org,tkent@chromium.org,jungkee.song@samsung.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=552309 Committed: https://crrev.com/0ef76e34a0795583225d399377873e8de2622b19 Cr-Commit-Position: refs/heads/master@{#369748}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -180 lines) Patch
M content/browser/service_worker/foreign_fetch_request_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_controllee_request_handler.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M content/browser/service_worker/service_worker_url_request_job.h View 2 chunks +0 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_url_request_job.cc View 4 chunks +0 lines, -4 lines 0 comments Download
M content/browser/service_worker/service_worker_url_request_job_unittest.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M content/common/service_worker/service_worker_messages.h View 2 chunks +0 lines, -2 lines 0 comments Download
M content/common/service_worker/service_worker_types.h View 2 chunks +0 lines, -2 lines 0 comments Download
M content/renderer/service_worker/service_worker_context_client.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-event.html View 6 chunks +12 lines, -48 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/fetch-event-test-worker.js View 3 chunks +4 lines, -20 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/interfaces-worker.js View 1 chunk +23 lines, -41 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/FetchEvent.h View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/FetchEvent.idl View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/FetchEventInit.idl View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebServiceWorkerRequest.cpp View 5 chunks +0 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerRequest.h View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
huangs
Created Revert of Service Worker: Add FetchEvent.clientId
4 years, 11 months ago (2016-01-15 15:15:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1588003005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1588003005/1
4 years, 11 months ago (2016-01-15 15:15:54 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-15 15:17:08 UTC) #4
commit-bot: I haz the power
4 years, 11 months ago (2016-01-15 15:18:29 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0ef76e34a0795583225d399377873e8de2622b19
Cr-Commit-Position: refs/heads/master@{#369748}

Powered by Google App Engine
This is Rietveld 408576698