Use common generated file for inputMethodPrivate APIs.

Use common generated file for inputMethodPrivate APIs.

BUG=577485
TEST=No compiling errors.

Committed: https://crrev.com/2f192747d80aaae8a07290ac5cfdb27043353a3f
Cr-Commit-Position: refs/heads/master@{#369963}

[Azure Wei, 2016-01-14 03:21:42]

Description was changed from

==========
Use common generated file for inputMethodPrivate APIs.

BUG=577485
TEST=No compiling errors.
==========

to

==========
Use common generated file for inputMethodPrivate APIs.

BUG=577485
TEST=No compiling errors.
==========

[Azure Wei, 2016-01-14 03:21:42]

azurewei@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org, shuchen@chromium.org

[Azure Wei, 2016-01-14 03:22:31]

Hi Devlin, Shu Chen, can you please help review this CL? Thank you!

[Shu Chen, 2016-01-14 03:49:56]

https://codereview.chromium.org/1587913002/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/extensions/input_method_api.cc (right):

https://codereview.chromium.org/1587913002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/extensions/input_method_api.cc:152:
EXTENSION_FUNCTION_VALIDATE(args_->GetString(0, &word));
Pls use the generated classes for parameters.

https://codereview.chromium.org/1587913002/diff/20001/chrome/common/extension...
File chrome/common/extensions/api/schemas.gypi (right):

https://codereview.chromium.org/1587913002/diff/20001/chrome/common/extension...
chrome/common/extensions/api/schemas.gypi:131: 'input_method_private.json',
I think this should be in alphabet order.

[Azure Wei, 2016-01-14 04:17:04]

https://codereview.chromium.org/1587913002/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/extensions/input_method_api.cc (right):

https://codereview.chromium.org/1587913002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/extensions/input_method_api.cc:152:
EXTENSION_FUNCTION_VALIDATE(args_->GetString(0, &word));
On 2016/01/14 03:49:56, Shu Chen wrote:
> Pls use the generated classes for parameters.

Done.

https://codereview.chromium.org/1587913002/diff/20001/chrome/common/extension...
File chrome/common/extensions/api/schemas.gypi (right):

https://codereview.chromium.org/1587913002/diff/20001/chrome/common/extension...
chrome/common/extensions/api/schemas.gypi:131: 'input_method_private.json',
On 2016/01/14 03:49:56, Shu Chen wrote:
> I think this should be in alphabet order.

Done.

[Shu Chen, 2016-01-14 04:21:46]

lgtm

[Devlin, 2016-01-15 22:12:03]

lgtm, thanks for doing this!

https://codereview.chromium.org/1587913002/diff/60001/chrome/browser/chromeos...
File chrome/browser/chromeos/extensions/input_method_api.cc (left):

https://codereview.chromium.org/1587913002/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/extensions/input_method_api.cc:193:
EventRouter::Get(context_)->RegisterObserver(this, kOnDictionaryLoaded);
I didn't think that we registered any event router observers by default.  Are
you sure you can safely delete these?

[Azure Wei, 2016-01-17 05:59:38]

On 2016/01/15 22:12:03, Devlin wrote:
> lgtm, thanks for doing this!
> 
>
https://codereview.chromium.org/1587913002/diff/60001/chrome/browser/chromeos...
> File chrome/browser/chromeos/extensions/input_method_api.cc (left):
> 
>
https://codereview.chromium.org/1587913002/diff/60001/chrome/browser/chromeos...
> chrome/browser/chromeos/extensions/input_method_api.cc:193:
> EventRouter::Get(context_)->RegisterObserver(this, kOnDictionaryLoaded);
> I didn't think that we registered any event router observers by default.  Are
> you sure you can safely delete these?

Thanks for pointing this out. I've added it back.

[Azure Wei, 2016-01-17 05:59:52]

The CQ bit was checked by azurewei@chromium.org

[Azure Wei, 2016-01-17 05:59:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org, shuchen@chromium.org
Link to the patchset: https://codereview.chromium.org/1587913002/#ps80001
(title: " ")

[Azure Wei, 2016-01-17 05:59:53]

The CQ bit was unchecked by azurewei@chromium.org

[Azure Wei, 2016-01-17 06:00:02]

The CQ bit was checked by azurewei@chromium.org

[commit-bot: I haz the power, 2016-01-17 06:00:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1587913002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1587913002/80001

[commit-bot: I haz the power, 2016-01-17 06:41:22]

Description was changed from

==========
Use common generated file for inputMethodPrivate APIs.

BUG=577485
TEST=No compiling errors.
==========

to

==========
Use common generated file for inputMethodPrivate APIs.

BUG=577485
TEST=No compiling errors.
==========

[commit-bot: I haz the power, 2016-01-17 06:41:23]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-01-17 06:42:30]

Description was changed from

==========
Use common generated file for inputMethodPrivate APIs.

BUG=577485
TEST=No compiling errors.
==========

to

==========
Use common generated file for inputMethodPrivate APIs.

BUG=577485
TEST=No compiling errors.

Committed: https://crrev.com/2f192747d80aaae8a07290ac5cfdb27043353a3f
Cr-Commit-Position: refs/heads/master@{#369963}
==========

[commit-bot: I haz the power, 2016-01-17 06:42:31]

Patchset 5 (id:??) landed as
https://crrev.com/2f192747d80aaae8a07290ac5cfdb27043353a3f
Cr-Commit-Position: refs/heads/master@{#369963}