Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1587803002:
[Media Router] Handle route swapping in the WebUI. (Closed)
Description[Media Router] Handle route swapping in the WebUI.
Handle the case when the display route for a device the user is currently viewing controls for is updated to a different route.
BUG=577335
Committed: https://crrev.com/f89b9c9425b918c35e342308802f17c77edb2f38
Cr-Commit-Position: refs/heads/master@{#369336}
Patch Set 1 #
Messages
Total messages: 18 (10 generated)
Description was changed from ========== remote route BUG= ========== to ========== [Work In Progress] Handle route swapping in the WebUI. BUG=577335 ==========
Description was changed from ========== [Work In Progress] Handle route swapping in the WebUI. BUG=577335 ========== to ========== Handle route swapping in the WebUI. BUG=577335 ==========
apacible@chromium.org changed reviewers: + imcheng@chromium.org, vadimgo@chromium.org
Description was changed from ========== Handle route swapping in the WebUI. BUG=577335 ========== to ========== Handle route swapping in the WebUI. Handle the case when the display route for a device the user is currently viewing controls for is updated to a different route. BUG=577335 ==========
PTAL, thanks!
lgtm
lgtm
Description was changed from ========== Handle route swapping in the WebUI. Handle the case when the display route for a device the user is currently viewing controls for is updated to a different route. BUG=577335 ========== to ========== [Media Router] Handle route swapping in the WebUI. Handle the case when the display route for a device the user is currently viewing controls for is updated to a different route. BUG=577335 ==========
The CQ bit was checked by apacible@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1587803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1587803002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_TIMED_OUT, no build URL) android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_TIMED_OUT, no build URL) android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_TIMED_OUT, no build URL) android_clang_dbg_recipe on tryserver.chromium.android (JOB_TIMED_OUT, no build URL) android_compile_dbg on tryserver.chromium.android (JOB_TIMED_OUT, no build URL) cast_shell_android on tryserver.chromium.android (JOB_TIMED_OUT, no build URL) linux_android_rel_ng on tryserver.chromium.android (JOB_TIMED_OUT, no build URL) cast_shell_linux on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) ios_rel_device_ninja on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) win8_chromium_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL) win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL) win_chromium_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL) win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by apacible@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1587803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1587803002/1
Message was sent while issue was closed.
Description was changed from ========== [Media Router] Handle route swapping in the WebUI. Handle the case when the display route for a device the user is currently viewing controls for is updated to a different route. BUG=577335 ========== to ========== [Media Router] Handle route swapping in the WebUI. Handle the case when the display route for a device the user is currently viewing controls for is updated to a different route. BUG=577335 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [Media Router] Handle route swapping in the WebUI. Handle the case when the display route for a device the user is currently viewing controls for is updated to a different route. BUG=577335 ========== to ========== [Media Router] Handle route swapping in the WebUI. Handle the case when the display route for a device the user is currently viewing controls for is updated to a different route. BUG=577335 Committed: https://crrev.com/f89b9c9425b918c35e342308802f17c77edb2f38 Cr-Commit-Position: refs/heads/master@{#369336} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/f89b9c9425b918c35e342308802f17c77edb2f38 Cr-Commit-Position: refs/heads/master@{#369336} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
